Merge pull request #5800 from grom72/pmempool-coverity-fix

pool: remove unreachable code
pmem · Jul 14, 2023 · 1d3c908 · 1d3c908
2 parents c9ce433 + 59b0015
commit 1d3c908
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/tools/pmempool/dump.c b/src/tools/pmempool/dump.c
@@ -171,21 +171,18 @@ pmempool_dump_func(const char *appname, int argc, char *argv[])
 	case PMEM_POOL_TYPE_OBJ:
 		outv_err("%s: PMEMOBJ pool not supported\n", pd.fname);
 		ret = -1;
-		goto out;
+		break;
 	case PMEM_POOL_TYPE_UNKNOWN:
 		outv_err("%s: unknown pool type -- '%s'\n", pd.fname,
 				params.signature);
 		ret = -1;
-		goto out;
+		break;
 	default:
 		outv_err("%s: cannot determine type of pool\n", pd.fname);
 		ret = -1;
-		goto out;
+		break;
 	}
 
-	if (ret)
-		outv_err("%s: dumping pool file failed\n", pd.fname);
-
 out:
 	if (pd.ofh != stdout)
 		fclose(pd.ofh);