Skip to content

Commit

Permalink
common: keep Valgrind enabled by default
Browse files Browse the repository at this point in the history
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
  • Loading branch information
grom72 committed Mar 20, 2024
1 parent 790d914 commit 229826c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pmem_test_matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Test prepare
uses: ./.github/actions/pmem_test_prepare
with:
valgrind: ${{ fromJSON(inputs.valgrind) }}
valgrind: ${{ inputs.valgrind }}

- name: Test run
uses: ./.github/actions/pmem_test_run
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/pmem_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
# 9h = 7h20m (the longest workflow execution time) + ~20% leeway.
timeout_minutes: 540


# Static builds are tested in this limited scope only.
static:
name: Static
Expand Down Expand Up @@ -109,3 +110,12 @@ jobs:
uses: ./.github/actions/pmem_test_run
with:
build: nondebug # only the production build is considered


# Test the default build with the basic test suite.
Basic_w_Valgrind:
uses: ./.github/workflows/pmem_test_matrix.yml
with:
# Exclude all Valgrind tests but keep Valgrind tools built-in.
force_enable: '["none"]'
valgrind: 1
1 change: 0 additions & 1 deletion src/test/valgrind_check/valgrind_check.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
* usage: valgrind_check
*
*/

#include "valgrind_internal.h"

#ifndef VALGRIND_ENABLED
Expand Down

0 comments on commit 229826c

Please sign in to comment.