test: introduce core_log() unit tests (fix)

- to be squashed before the merge Signed-off-by: Jan Michalski <jan.michalski@intel.com>
pmem · Mar 4, 2024 · 45d4187 · 45d4187
1 parent e02e67b
commit 45d4187
Show file tree

Hide file tree

Showing 12 changed files with 356 additions and 292 deletions.
diff --git a/src/core/log_internal.h b/src/core/log_internal.h
@@ -83,20 +83,6 @@ typedef void core_log_function(
 
 int core_log_set_function(core_log_function *log_function, void *context);
 
-/* pointer to the logging function */
-extern
-#ifdef ATOMIC_OPERATIONS_SUPPORTED
-_Atomic
-#endif /* ATOMIC_OPERATIONS_SUPPORTED */
-uintptr_t Core_log_function;
-
-/* the logging function's context */
-extern
-#ifdef ATOMIC_OPERATIONS_SUPPORTED
-_Atomic
-#endif /* ATOMIC_OPERATIONS_SUPPORTED */
-void *Core_log_function_context;
-
 /* threshold levels */
 extern
 #ifdef ATOMIC_OPERATIONS_SUPPORTED

diff --git a/src/test/Makefile b/src/test/Makefile
@@ -110,6 +110,7 @@ OTHER_TESTS = \
 	arch_flags\
 	core_log\
 	core_log_internal\
+	core_log_no_func\
 	core_log_max\
 	checksum\
 	compat_incompat_features\

diff --git a/src/test/core_log/Makefile b/src/test/core_log/Makefile
@@ -2,7 +2,7 @@
 # Copyright 2024, Intel Corporation
 
 TARGET = core_log
-OBJS = core_log.o
+OBJS = core_log.o core_log_common.o
 
 BUILD_STATIC_DEBUG=n
 BUILD_STATIC_NONDEBUG=n
@@ -11,4 +11,4 @@ BUILD_STATIC_NONDEBUG=n
 LIBPMEMCORE=internal-debug
 
 include ../Makefile.inc
-LDFLAGS += $(call extract_funcs, core_log.c)
+LDFLAGS += $(call extract_funcs, core_log_common.c)
diff --git a/src/test/core_log/TESTS.py b/src/test/core_log/TESTS.py
@@ -42,8 +42,4 @@ class TEST5(CORE_LOG):
 
 
 class TEST6(CORE_LOG):
-    test_case = 'test_no_log_function'
-
-
-class TEST7(CORE_LOG):
     test_case = 'test_happy_day'