Skip to content

Commit

Permalink
common: inrease total stack usage limit causes by new logging function
Browse files Browse the repository at this point in the history
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
  • Loading branch information
grom72 committed Feb 26, 2024
1 parent cba93a0 commit 7ff9616
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/scan_stack_usage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ jobs:
./make_extra.py
./make_cflow.sh
# The lower limit comes up from the DAOS memory requirements.
# 16kB - 4kB - 1kB = ~11kB
# 16kB - 4kB - 768B = 11520B
# 16kB = Stack allocated for a single Argobot's ULT
# 4kB = a maximum DAOS' stack usage up to calling a PMDK API calls
# 1kB = safety margin
# 768B = safety margin
# ~ = Some OSes, e.g. Ubuntu 22.04, generate call stacks of size
# a little bit over the exact limit which is not deemed a problem at the moment.
./make_call_stacks.py --filter-api-file examples/api_filter.txt --filter-lower-limit 11296
./make_call_stacks.py --filter-api-file examples/api_filter.txt --filter-lower-limit 11520
- name: List per-function stack usage for all call stacks of interest
working-directory: ${{ env.CALL_STACKS_TOOLS_PATH }}
Expand Down
2 changes: 1 addition & 1 deletion utils/call_stacks_analysis/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
./make_extra.py && \
./make_cflow.sh && \
./make_call_stacks.py --filter-api-file examples/api_filter.txt \
--filter-lower-limit 11296 --dump-all-stacks
--filter-lower-limit 11520 --dump-all-stacks
```

If succesfull, it produces:
Expand Down

0 comments on commit 7ff9616

Please sign in to comment.