core: handle ENOMEM gracefully during logging #5536
Conversation
src/core/out.c
Outdated
| if (errormsg == NULL) | ||
| FATAL("!malloc"); | ||
| if (errormsg == NULL) { | ||
| ERR("!malloc"); |
There was a problem hiding this comment.
this will recurse I think, just return NULL.
There was a problem hiding this comment.
Oops, sorry, looks like I forgot what the original problem is... :-(
src/core/out.c
Outdated
| @@ -425,6 +428,11 @@ out_error(const char *file, int line, const char *func, | |||
|
|
|||
| char *errormsg = (char *)out_get_errormsg(); | |||
|
|
|||
| if (errormsg == NULL) { | |||
| ERR("There's no memory to properly format error strings."); | |||
There was a problem hiding this comment.
Same problem. Here I think you can just do Print("There's no memory to properly format error strings.");
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @bfaccini)
bfaccini
requested review from
pbalcer and
lukaszstolarczuk
and removed request for
pbalcer and
lukaszstolarczuk
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @bfaccini and @pbalcer)
-- commits line 2 at r3:
I guess you can squash your commits to just have the single one
src/core/out.c line 2 at r3 (raw file):
// SPDX-License-Identifier: BSD-3-Clause /* Copyright 2014-2021, Intel Corporation */
Since you're using an intel e-mail address for your commits, you have to bump the copyright's date: 2014-2023
|
och, I guess you can also un-draft this PR...? |
In order to survive and get an explicit message upon ENOMEM situation during logging, use a static generic message. Ref: pmem/issues#5515 Signed-off-by: Bruno Faccini <bruno.faccini@intel.com>
bfaccini
force-pushed
the
changes_for_issue_5515_1
branch
from
f2f92c2
to
0a8add6
Compare
Done
Done |
Done |
Codecov Report
@@ Coverage Diff @@
## master #5536 +/- ##
==========================================
- Coverage 71.62% 71.61% -0.01%
==========================================
Files 162 162
Lines 24256 24259 +3
==========================================
Hits 17373 17373
- Misses 6883 6886 +3 |
There was a problem hiding this comment.
thx
👍
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pbalcer)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pbalcer)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pbalcer)
In order to survive and get an explicit message upon ENOMEM situation during logging, use a static generic message.
Ref: pmem/issues #5515
Signed-off-by: Bruno Faccini bruno.faccini@intel.com
This change is