-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: Unified pmem tests #5740
Conversation
064eb68
to
478199f
Compare
478199f
to
c4aaeca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Respect. This is one huge step forward.
Reviewed 4 of 10 files at r4, 7 of 12 files at r5, 26 of 29 files at r6, 3 of 3 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)
.github/workflows/pmem_check.yml
line 20 at r8 (raw file):
'check TEST_BUILD=nondebug', 'check TEST_BUILD=static-debug', 'check TEST_BUILD=static-nondebug',
Wow. Another variation? Did it work at all?
.github/workflows/pmem_valgrind.yml
line 21 at r8 (raw file):
matrix: config: ['drd', 'pmemcheck', 'memcheck', 'helgrind'] build: ['debug', 'release', 'static_debug', 'static_release']
How has it worked previously? AFAIK there is no "release" PMDK release, isn't it? 🤣
c4aaeca
to
e4bdeb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 41 files reviewed, 2 unresolved discussions (waiting on @janekmi)
.github/workflows/pmem_check.yml
line 20 at r8 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Wow. Another variation? Did it work at all?
Yes,
.github/workflows/pmem_valgrind.yml
line 21 at r8 (raw file):
Previously, janekmi (Jan Michalski) wrote…
How has it worked previously? AFAIK there is no "release" PMDK release, isn't it? 🤣
Please, see RELEASE_LIBDIR
-> NONDEBUG_LIBDIR
in consts.py
and combine it with class Release(Build)
-> class NonDebug(Build)
in builds.py
release
term has only been used by RUNTESTS.py and converted to use nondebug libraries:
RELEASE_LIBDIR = abspath(join(ROOTDIR, '..', 'nondebug'))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 12 files at r5, 26 of 33 files at r10, 3 of 7 files at r11, 5 of 5 files at r12, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 7 files at r11, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 12 files at r5, 26 of 33 files at r10, 3 of 7 files at r11, 5 of 5 files at r12, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
e4bdeb1
to
47ee596
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 26 of 33 files at r10, 1 of 7 files at r11, 5 of 5 files at r12, 3 of 33 files at r13, 22 of 29 files at r14, 3 of 7 files at r15, 5 of 5 files at r16, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
unify builds names - _debug instead of -debug _nondebug instead of -nondebug Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
The second PR (out of two) unifies how Bash and Python main test scripts can be called from GHA.
In this PR:
--
release
->nondebug
--
static-debug
->static_debug
andstatic-nondebug
->static_nondebug
(underscore_
instead of dash-
)pmem_valgrind.yml
, instead of two separate files for Python and Bashpmem_long.yml
) has been simplifiedRequires:
This PR is a pre-work for #5702.
This change is