common: a playbook for GHA self-hosted runner configuration #5742

grom72 · 2023-06-21T11:01:20Z

This change is

janekmi

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 18 unresolved discussions (waiting on @grom72)

utils/ansible/configure-selfhosted-runner.yml line 4 at r1 (raw file):

# Copyright 2023, Intel Corporation

# This playbook is designed to add runner to GHA on pmem/pmdk.

a runner

utils/ansible/configure-selfhosted-runner.yml line 4 at r1 (raw file):

# Copyright 2023, Intel Corporation

# This playbook is designed to add runner to GHA on pmem/pmdk.

Is it for pmem/pmdk only?

utils/ansible/configure-selfhosted-runner.yml line 5 at r1 (raw file):

Examples below show how to use this file:

utils/ansible/configure-selfhosted-runner.yml line 10 at r1 (raw file):

# sudo ansible-playbook ./configure-selfhosted-runner.yml --extra-vars
# "testUser=pmdkuser runner_name=name labels=$LABELS vars_gha=env1,env2 token=gha_token"
# For a playbok to be used on local server please

playbook

utils/ansible/configure-selfhosted-runner.yml line 10 at r1 (raw file):

# sudo ansible-playbook ./configure-selfhosted-runner.yml --extra-vars
# "testUser=pmdkuser runner_name=name labels=$LABELS vars_gha=env1,env2 token=gha_token"
# For a playbok to be used on local server please

a local server please:

utils/ansible/configure-selfhosted-runner.yml line 12 at r1 (raw file):

# For a playbok to be used on local server please
# a) comment the first command: # -hosts: "{{ host }}"
# b) uncomment next two lines:

the next two...

utils/ansible/configure-selfhosted-runner.yml line 31 at r1 (raw file):

    runner_folder: /home/{{ testUser }}/actions-runner
    repo_url: https://github.com/pmem/pmdk
    vars_list: "{{ vars_gha.split(',') }}"

Missing var(s):

labels
token
runner_name

utils/ansible/configure-selfhosted-runner.yml line 48 at r1 (raw file):

    - name: "Change owner to {{ testUser }}"
      shell: |
        chown -R {{ testUser }} {{ runner_folder }}

A missing new line after a step.

utils/ansible/configure-selfhosted-runner.yml line 48 at r1 (raw file):

    - name: "Change owner to {{ testUser }}"
      shell: |
        chown -R {{ testUser }} {{ runner_folder }}

shell: chown -R {{ testUser }} {{ runner_folder }}

You do not need two lines for this one.

utils/ansible/configure-selfhosted-runner.yml line 59 at r1 (raw file):

      shell: |
        cd {{ runner_folder }}
        ./svc.sh install {{ testUser }}

A missing new line.

utils/ansible/configure-selfhosted-runner.yml line 70 at r1 (raw file):

      shell: |
        systemctl enable actions.runner.pmem-pmdk.{{ runner_name }}.service
        systemctl restart actions.runner.pmem-pmdk.{{ runner_name }}.service

A missing new line.

utils/ansible/README.md line 102 at r1 (raw file):

sudo ansible-playbook ./configure-pmem.yml --extra-vars "testUser=pmdkuser"

This is the point where I would like to see it.
The example below should already show how to use this new playbook.
We do not need two ways of setting up runners. Let it be a playbook and nothing else.

utils/ansible/README.md line 167 at r1 (raw file):

## Installing and setting up a GitHub Actions runner
Installation and configuration of a self-hosted runner (as pmdkuser):
```sh

And I would like to see the new playbook used here instead of showing how to do it manually.

utils/ansible/README.md line 178 at r1 (raw file):

Close session leaving the tmux session in the background (`CTRL+b d`).

# Installing a GitHub Action runner using Ansible palybook

~~using Ansible palybook~~

Obvious considering my comment above.

Ref: https://reviewable.io/reviews/pmem/pmdk/5742#-NYYavz_Aa7tnzZjQDkW

utils/ansible/README.md line 179 at r1 (raw file):

... a CI environment...

utils/ansible/README.md line 185 at r1 (raw file):

... a new...

utils/ansible/README.md line 186 at r1 (raw file):

host's name as it will be visible on GitHub (e.g. hostname)

utils/ansible/README.md line 187 at r1 (raw file):
A missing space.

# rhel...

janekmi

Reviewable status: all files reviewed, 19 unresolved discussions (waiting on @grom72)

utils/ansible/README.md line 188 at r1 (raw file):

export HOST_NAME= # Host name that will be visible on GitHub (e.g.) `hostname`
export LABELS= #rhel or opensuse
ansible-playbook -i $TARGET_IP, configure-selfhosted-runner.yml --extra-vars

,?

grom72

Reviewable status: 0 of 4 files reviewed, 19 unresolved discussions (waiting on @grom72 and @janekmi)

utils/ansible/README.md line 102 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

This is the point where I would like to see it.
The example below should already show how to use this new playbook.
We do not need two ways of setting up runners. Let it be a playbook and nothing else.

Done.

utils/ansible/README.md line 167 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

And I would like to see the new playbook used here instead of showing how to do it manually.

Done.

utils/ansible/README.md line 178 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

~~using Ansible palybook~~

Obvious considering my comment above.

Ref: https://reviewable.io/reviews/pmem/pmdk/5742#-NYYavz_Aa7tnzZjQDkW

Done.

utils/ansible/README.md line 179 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

... a CI environment...

Done.

utils/ansible/README.md line 185 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

... a new...

Done.

utils/ansible/README.md line 186 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

host's name as it will be visible on GitHub (e.g. hostname)

Done.

utils/ansible/README.md line 187 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

A missing space.

# rhel...

Done.

utils/ansible/README.md line 188 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

,?

The following warning is reported by ansible-playbook without it:

[WARNING]: Unable to parse /home/tgromadz/repos/pmdk/utils/ansible/10.91.28.220 as an inventory source
[WARNING]: No inventory was parsed, only implicit localhost is available
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'

utils/ansible/configure-selfhosted-runner.yml line 4 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Is it for pmem/pmdk only?

Yes, as long as you do not modify it.

utils/ansible/configure-selfhosted-runner.yml line 4 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

a runner

Done.

utils/ansible/configure-selfhosted-runner.yml line 5 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Examples below show how to use this file:

Done.

utils/ansible/configure-selfhosted-runner.yml line 10 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

a local server please:

Done.

utils/ansible/configure-selfhosted-runner.yml line 10 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

playbook

Done.

utils/ansible/configure-selfhosted-runner.yml line 12 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

the next two...

Done.

utils/ansible/configure-selfhosted-runner.yml line 48 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

shell: chown -R {{ testUser }} {{ runner_folder }}
You do not need two lines for this one.

Done.

utils/ansible/configure-selfhosted-runner.yml line 48 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

A missing new line after a step.

Done.

utils/ansible/configure-selfhosted-runner.yml line 59 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

A missing new line.

Done.

utils/ansible/configure-selfhosted-runner.yml line 70 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

A missing new line.

Done.

grom72

Reviewable status: 0 of 4 files reviewed, 19 unresolved discussions (waiting on @janekmi)

utils/ansible/configure-selfhosted-runner.yml line 31 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Missing var(s):

labels

token

runner_name

No. They are obligatory.

codecov · 2023-06-23T10:40:11Z

Codecov Report

Merging #5742 (f8b285b) into master (54c43c6) will not change coverage.
The diff coverage is n/a.

❗ Current head f8b285b differs from pull request most recent head a9aa77b. Consider uploading reports for the commit a9aa77b to get more accurate results

@@           Coverage Diff           @@
##           master    #5742   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files         143      143           
  Lines       21978    21978           
  Branches     3696     3696           
=======================================
  Hits        16240    16240           
  Misses       5738     5738

janekmi

Reviewed 1 of 3 files at r2, 1 of 3 files at r3, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 21 unresolved discussions (waiting on @grom72)

utils/ansible/ansible.cfg line 1 at r5 (raw file):

[defaults]

Please tell me more about why this file is necessary and what exactly changes have been made compared to the default one.

utils/ansible/configure-self-hosted-runner.yml line 6 at r5 (raw file):

# This playbook is designed to add a new self-hosted runner to pmem/pmdk.
# Examples below show how to use this file:
# 1) remote

remotely

utils/ansible/configure-self-hosted-runner.yml line 9 at r5 (raw file):

# export TARGET_IP= # ip of the target
# export ROOT_PASSWORD= # a password of root on the target
# export GHA_TOKEN= # GitHub token generated for a new self-hosted runner

a GitHub token

utils/ansible/configure-self-hosted-runner.yml line 19 at r5 (raw file):

# 2) locally
# For a playbook to be used on a local server please:
# a) comment the first command: # -hosts: "{{ host }}"

comment out

utils/ansible/configure-self-hosted-runner.yml line 24 at r5 (raw file):

#   connection: local
#
# export GHA_TOKEN= # GitHub token generated for a new self-hosted runner

a GitHub token

utils/ansible/configure-self-hosted-runner.yml line 25 at r5 (raw file):

#
# export GHA_TOKEN= # GitHub token generated for a new self-hosted runner
# export HOST_NAME= # Host name that will be visible on GitHub (e.g. `hostname`)

Please make it the same as the HOST_NAME above.

utils/ansible/configure-self-hosted-runner.yml line 26 at r5 (raw file):

# export GHA_TOKEN= # GitHub token generated for a new self-hosted runner
# export HOST_NAME= # Host name that will be visible on GitHub (e.g. `hostname`)
# export LABELS= #rhel or opensuse

A missing space.

utils/ansible/configure-self-hosted-runner.yml line 29 at r5 (raw file):

# export VARS_GHA=http_proxy=http://proxy-dmz.XXX.com:911,https_proxy=http://proxy-dmz.XXX.com:912
# ansible-playbook configure-self-hosted-runner.yml --extra-vars \
# "runner_name=$HOST_NAME labels=$LABELS vars_gha=env1,env2 token=$GHA_TOKEN"

Please indent.

utils/ansible/configure-self-hosted-runner.yml line 33 at r5 (raw file):

#
# Runner package version may be changed by: --extra-vars package_url=<url_to_package.tar.gz>

The runner package version...

utils/ansible/configure-self-hosted-runner.yml line 43 at r5 (raw file):

    runner_folder: /home/{{ testUser }}/actions-runner
    repo_url: https://github.com/pmem/pmdk
    vars_list: "{{ vars_gha.split(',') }}"

Should all the named variables which are passed to the playbook be enumerated here?

Even if not, I think it might be helpful to make this script self-contained if you will. Otherwise, you have to find the names of the required arguments in the README or by browsing the script. What do you think?

utils/ansible/README.md line 6 at r5 (raw file):

The scripts in this directory allow you to set up a RockyLinux and OpenSUSE
environment on a real hardware to be able build a PMDK project on it or use the

to build...

utils/ansible/README.md line 7 at r5 (raw file):

The scripts in this directory allow you to set up a RockyLinux and OpenSUSE
environment on a real hardware to be able build a PMDK project on it or use the
node as a self-hosted runner for pmem/pmdk repository.

for the pmem/pmdk repository...

utils/ansible/README.md line 76 at r5 (raw file):

Installing a GitHub Action self-hosted runner using Ansible palybook

~~using Ansible palybook~~

Obvious.

utils/ansible/README.md line 79 at r5 (raw file):
Reading this paragraph I could not get rid of the impression that the sequence below will do everything for me (CI env, pmem and GHA self-hosted runner setup).

I feel this wording might be slightly less confusing:

Having a server with persistent memory and a CI environment already installed, the sequence of commands below sets up the server as a self-hosted runner for the pmem/pmdk repository.

What do you think?

utils/ansible/README.md line 84 at r5 (raw file):

export TARGET_IP= # ip of the target
export ROOT_PASSWORD= # a password of root on the target
export GHA_TOKEN= # GitHub token generated for a new self-hosted runner

a GitHub token

utils/ansible/README.md line 88 at r5 (raw file):

export LABELS= # rhel or opensuse
export VARS_GHA= # e.g. proxy settings: http_proxy=http://proxy-dmz.XXX.com:911,https_proxy=http://proxy-dmz.XXX.com:912
ansible-playbook -i $TARGET_IP, configure-self-hosted-runner.yml --extra-vars

Missing \ at the end of the line.

utils/ansible/README.md line 93 at r5 (raw file):

Note: To obtain a token for a new self hosted runer visit
Create self-hosted runner

gib -> github

utils/ansible/README.md line 96 at r5 (raw file):

.

**Note**: In case of any problems, please refer to

to the XXX documentation.

utils/ansible/README.md line 158 at r5 (raw file):

ansible-playbook configure-pmem.yml --extra-vars "testUser=pmdkuser"

export GHA_TOKEN= # GitHub token generated for a new self-hosted runner

a GitHub token

utils/ansible/README.md line 163 at r5 (raw file):

export VARS_GHA=http_proxy=http://proxy-dmz.XXX.com:911,https_proxy=http://proxy-dmz.XXX.com:912
ansible-playbook configure-self-hosted-runner.yml -extra-vars \
"testUser=pmdkuser runner_name=$HOST_NAME labels=$LABELS token=$GHA_TOKEN vars_gha=$VARS_GHA"

Please indent.

utils/ansible/README.md line 195 at r5 (raw file):

export GHA_TOKEN= # GitHub token generated for a new self-hosted runner
export HOST_NAME=`hostname`
export LABELS= opensuse

Unnecessary space between = and opensuse.

grom72

Reviewed 1 of 3 files at r2, 2 of 2 files at r6.
Reviewable status: all files reviewed (commit messages unreviewed), 21 unresolved discussions (waiting on @janekmi)

utils/ansible/ansible.cfg line 1 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Please tell me more about why this file is necessary and what exactly changes have been made compared to the default one.

host_key_checking=False flag is needed to enable password-based authorization

utils/ansible/configure-self-hosted-runner.yml line 6 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

remotely

Done.

utils/ansible/configure-self-hosted-runner.yml line 9 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

a GitHub token

Done.

utils/ansible/configure-self-hosted-runner.yml line 19 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

comment out

Done.

utils/ansible/configure-self-hosted-runner.yml line 24 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

a GitHub token

Done.

utils/ansible/configure-self-hosted-runner.yml line 25 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Please make it the same as the HOST_NAME above.

here we could use directly the result of hostname command

utils/ansible/configure-self-hosted-runner.yml line 26 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

A missing space.

Done.

utils/ansible/configure-self-hosted-runner.yml line 29 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Please indent.

Done.

utils/ansible/configure-self-hosted-runner.yml line 33 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

The runner package version...

Done.

utils/ansible/configure-self-hosted-runner.yml line 43 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Should all the named variables which are passed to the playbook be enumerated here?

Even if not, I think it might be helpful to make this script self-contained if you will. Otherwise, you have to find the names of the required arguments in the README or by browsing the script. What do you think?

Done, but if we add all named variables, we will force the user to modify this file every time.

utils/ansible/README.md line 6 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

to build...

Done.

utils/ansible/README.md line 7 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

for the pmem/pmdk repository...

Done.

utils/ansible/README.md line 76 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

~~using Ansible palybook~~

Obvious.

Done.

utils/ansible/README.md line 79 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Reading this paragraph I could not get rid of the impression that the sequence below will do everything for me (CI env, pmem and GHA self-hosted runner setup).

I feel this wording might be slightly less confusing:

Having a server with persistent memory and a CI environment already installed, the sequence of commands below sets up the server as a self-hosted runner for the pmem/pmdk repository.

What do you think?

Done.

utils/ansible/README.md line 84 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

a GitHub token

Done.

utils/ansible/README.md line 88 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Missing \ at the end of the line.

Done.

utils/ansible/README.md line 93 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

gib -> github

Done.

utils/ansible/README.md line 96 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

to the XXX documentation.

Done.

utils/ansible/README.md line 158 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

a GitHub token

Done.

utils/ansible/README.md line 163 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Please indent.

Done.

utils/ansible/README.md line 195 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Unnecessary space between = and opensuse.

Done.

grom72

Reviewed all commit messages.
Reviewable status: all files reviewed, 21 unresolved discussions (waiting on @janekmi)

janekmi

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

utils/ansible/ansible.cfg line 1 at r5 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

host_key_checking=False flag is needed to enable password-based authorization

TBH it does not look like this is doing what you are using it for. If I understand correctly, this option allows skipping the host key verification. So you do not have to add it manually beforehand.

Adding this whole file only to set a single parameter looks very bad. What would you say to recommend using the ANSIBLE_HOST_KEY_CHECKING environment variable in case host key verification fails and adding host keys is too cumbersome?

Ref: https://docs.ansible.com/ansible/latest/reference_appendices/config.html#host-key-checking

grom72

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

utils/ansible/ansible.cfg line 1 at r5 (raw file):

Previously, janekmi (Jan Michalski) wrote…

TBH it does not look like this is doing what you are using it for. If I understand correctly, this option allows skipping the host key verification. So you do not have to add it manually beforehand.

Adding this whole file only to set a single parameter looks very bad. What would you say to recommend using the ANSIBLE_HOST_KEY_CHECKING environment variable in case host key verification fails and adding host keys is too cumbersome?

Ref: https://docs.ansible.com/ansible/latest/reference_appendices/config.html#host-key-checking

You have to add this variable to every command.

grom72

Reviewed 1 of 3 files at r7.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @janekmi)

utils/ansible/ansible.cfg line 1 at r5 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

You have to add this variable to every command.

Done.

janekmi

Reviewed 1 of 3 files at r7, 2 of 2 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

utils/ansible/ansible.cfg line 2 at r8 (raw file):

[defaults]
# (boolean) Set this to "False" if you want to avoid host key checking by the underlying tools Ansible uses to connect to the host

TBH this comment does not convey the purpose of configuring this setting. I think it would be nice to add another line e.g.

# Turning off the host key authorization allows using password authorization instead.

janekmi

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

utils/ansible/ansible.cfg line 2 at r8 (raw file):

Previously, janekmi (Jan Michalski) wrote…

TBH this comment does not convey the purpose of configuring this setting. I think it would be nice to add another line e.g.
# Turning off the host key authorization allows using password authorization instead.

Ok. I guess the information in the commit message is sufficient.

Enable simple authorization with root password instead of ssh host key authorization. See host_key_checking flag. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>

grom72

Reviewed 2 of 3 files at r7, 1 of 3 files at r9, 2 of 2 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

utils/ansible/ansible.cfg line 2 at r8 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Ok. I guess the information in the commit message is sufficient.

Done

janekmi

Reviewed 1 of 3 files at r9, 2 of 2 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

osalyk

Reviewed 1 of 3 files at r3, 1 of 3 files at r9, 2 of 2 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

grom72 added Priority: 3 medium QA: CI .github/ and utils/ related to automated testing labels Jun 21, 2023

grom72 added this to the 2.0.0 milestone Jun 21, 2023

grom72 requested a review from janekmi June 21, 2023 11:01

janekmi requested changes Jun 22, 2023

View reviewed changes

grom72 force-pushed the ghaRunnerProvisioning branch 3 times, most recently from 0ff9c34 to bda2505 Compare June 23, 2023 09:46

grom72 commented Jun 23, 2023

View reviewed changes

grom72 force-pushed the ghaRunnerProvisioning branch from bda2505 to 163006c Compare June 23, 2023 09:53

grom72 commented Jun 23, 2023

View reviewed changes

janekmi requested changes Jun 23, 2023

View reviewed changes

grom72 force-pushed the ghaRunnerProvisioning branch 2 times, most recently from f8b285b to 894102b Compare June 26, 2023 10:44

grom72 commented Jun 26, 2023

View reviewed changes

janekmi requested changes Jun 26, 2023

View reviewed changes

grom72 commented Jun 26, 2023

View reviewed changes

grom72 force-pushed the ghaRunnerProvisioning branch from 894102b to b42bb6d Compare June 26, 2023 11:17

grom72 commented Jun 26, 2023

View reviewed changes

janekmi requested changes Jun 26, 2023

View reviewed changes

janekmi approved these changes Jun 26, 2023

View reviewed changes

grom72 added 2 commits June 26, 2023 17:51

common: avoid host key checking by ansible

85c30cf

Enable simple authorization with root password instead of ssh host key authorization. See host_key_checking flag. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>

common: a playbook for GHA self-hosted runner configuration

a9aa77b

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>

grom72 force-pushed the ghaRunnerProvisioning branch from b42bb6d to a9aa77b Compare June 26, 2023 15:56

grom72 commented Jun 26, 2023

View reviewed changes

janekmi approved these changes Jun 26, 2023

View reviewed changes

osalyk approved these changes Jun 30, 2023

View reviewed changes

janekmi merged commit 2d864ff into pmem:master Jun 30, 2023
30 checks passed

grom72 deleted the ghaRunnerProvisioning branch July 3, 2023 07:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

common: a playbook for GHA self-hosted runner configuration #5742

common: a playbook for GHA self-hosted runner configuration #5742

grom72 commented Jun 21, 2023 •

edited by pbalcer

Loading

janekmi left a comment

janekmi left a comment

grom72 left a comment

grom72 left a comment

codecov bot commented Jun 23, 2023 •

edited

Loading

janekmi left a comment

grom72 left a comment

grom72 left a comment

janekmi left a comment

grom72 left a comment

grom72 left a comment

janekmi left a comment

janekmi left a comment

grom72 left a comment

janekmi left a comment

osalyk left a comment

common: a playbook for GHA self-hosted runner configuration #5742

common: a playbook for GHA self-hosted runner configuration #5742

Conversation

grom72 commented Jun 21, 2023 • edited by pbalcer Loading

janekmi left a comment

Choose a reason for hiding this comment

janekmi left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 23, 2023 • edited Loading

Codecov Report

janekmi left a comment

Choose a reason for hiding this comment

Installing a GitHub Action self-hosted runner using Ansible palybook

grom72 left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

janekmi left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

janekmi left a comment

Choose a reason for hiding this comment

janekmi left a comment

Choose a reason for hiding this comment

grom72 left a comment

Choose a reason for hiding this comment

janekmi left a comment

Choose a reason for hiding this comment

osalyk left a comment

Choose a reason for hiding this comment

grom72 commented Jun 21, 2023 •

edited by pbalcer

Loading

codecov bot commented Jun 23, 2023 •

edited

Loading