-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable pmempool_sync/TEST18 until #5708 is fixed #5796
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5796 +/- ##
==========================================
- Coverage 70.98% 68.75% -2.24%
==========================================
Files 131 131
Lines 19175 19677 +502
Branches 3193 3258 +65
==========================================
- Hits 13612 13529 -83
- Misses 5563 6148 +585 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)
a discussion (no related file):
Please rebase.
src/test/pmempool_sync/TEST18
line 14 at r3 (raw file):
. ../unittest/unittest.sh #XXX Disable tests for all configuration until the issue #5708 is fixed.
Suggestion:
# XXX Disable tests for all configurations until issue #5708 is fixed.
c082f5e
to
bab48dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)
a discussion (no related file):
Previously, janekmi (Jan Michalski) wrote…
Please rebase.
Done.
src/test/pmempool_sync/TEST18
line 14 at r3 (raw file):
. ../unittest/unittest.sh #XXX Disable tests for all configuration until the issue #5708 is fixed.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)
Disable tests for all configuration until the issue pmem#5708 is fixed. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
bab48dd
to
b542a1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
Disable tests for all configurations until issue #5708 is fixed.
Requires:
This change is