Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable pmempool_sync/TEST18 until #5708 is fixed #5796

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jul 13, 2023

Disable tests for all configurations until issue #5708 is fixed.

Requires:


This change is Reviewable

@grom72 grom72 added QA: CI .github/ and utils/ related to automated testing sprint goal This pull request is part of the ongoing sprint labels Jul 13, 2023
@grom72 grom72 added this to the 2.0.0 milestone Jul 13, 2023
@grom72 grom72 requested review from janekmi and osalyk July 13, 2023 06:46
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #5796 (bab48dd) into master (91711db) will decrease coverage by 2.24%.
The diff coverage is n/a.

❗ Current head bab48dd differs from pull request most recent head b542a1d. Consider uploading reports for the commit b542a1d to get more accurate results

@@            Coverage Diff             @@
##           master    #5796      +/-   ##
==========================================
- Coverage   70.98%   68.75%   -2.24%     
==========================================
  Files         131      131              
  Lines       19175    19677     +502     
  Branches     3193     3258      +65     
==========================================
- Hits        13612    13529      -83     
- Misses       5563     6148     +585     

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)

a discussion (no related file):
Please rebase.



src/test/pmempool_sync/TEST18 line 14 at r3 (raw file):

. ../unittest/unittest.sh

#XXX Disable tests for all configuration until the issue #5708 is fixed.

Suggestion:

# XXX Disable tests for all configurations until issue #5708 is fixed.

@grom72 grom72 force-pushed the test-dissable-5708 branch 2 times, most recently from c082f5e to bab48dd Compare July 13, 2023 19:46
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)

a discussion (no related file):

Previously, janekmi (Jan Michalski) wrote…

Please rebase.

Done.



src/test/pmempool_sync/TEST18 line 14 at r3 (raw file):

. ../unittest/unittest.sh

#XXX Disable tests for all configuration until the issue #5708 is fixed.

Done.

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)

Disable tests for all configuration until the issue pmem#5708 is fixed.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit 230334e into pmem:master Jul 14, 2023
@grom72 grom72 deleted the test-dissable-5708 branch October 24, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: CI .github/ and utils/ related to automated testing sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants