common: restore the env.py ansible library #5798
Conversation
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
grom72
added
QA: CI
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
Codecov Report
@@ Coverage Diff @@
## master #5798 +/- ##
==========================================
+ Coverage 68.75% 70.98% +2.23%
==========================================
Files 131 131
Lines 19677 19175 -502
Branches 3259 3193 -66
==========================================
+ Hits 13529 13612 +83
+ Misses 6148 5563 -585 |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
utils/ansible/library/env.py line 42 at r1 (raw file):
default: /etc/profile.d/ansible_env_module_definitions.sh author: - dpysx
Who is the author? Consequently, are we 100% sure this module is BSD-3 licensed?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
utils/ansible/library/env.py line 42 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Who is the author? Consequently, are we 100% sure this module is BSD-3 licensed?
We have established offline that all the authors are Intel employees.
utils/ansible/library/env.py line 42 at r1 (raw file):
default: /etc/profile.d/ansible_env_module_definitions.sh author: - dpysx
Please drop these lines. We do not tend to name individual contributors this way.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
This change is