common: move PKG-specific variables out of the testconfig generating … #5802
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grom72
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
janekmi
force-pushed
the
pkg-specific-paths-added-somewhere-else
branch
from
925de71
to
2588011
Compare
osalyk
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
grom72
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Codecov Report
@@ Coverage Diff @@
## master #5802 +/- ##
==========================================
- Coverage 70.98% 68.74% -2.25%
==========================================
Files 131 131
Lines 19175 19677 +502
Branches 3193 3259 +66
==========================================
- Hits 13612 13527 -85
- Misses 5563 6150 +587 |
…script Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi
added a commit
that referenced
this pull request
Jul 26, 2023
...generating script Ref: #5802 Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi
added a commit
that referenced
this pull request
Jul 26, 2023
...generating script Ref: #5802 Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi
added a commit
to janekmi/pmdk
that referenced
this pull request
Jul 26, 2023
...generating script Ref: pmem#5802 Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…script
This change is