-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: Update configure runner and opensuse setup scripts #5816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @szczepax)
a discussion (no related file):
You may also want to fix this line in the commit message:
chown should also change the group for actions-runner folder,
utils/ansible/configure-self-hosted-runner.yml
line 62 at r1 (raw file):
- name: "Change owner to {{ testUser }}" shell: chown -R $(id -u {{ testUser }}).$(id -g {{ testUser }}) {{ runner_folder }}
I believe you should use :
instead of .
to separate OWNER and GROUP.
Suggestion:
chown -R $(id -u {{ testUser }}):$(id -g {{ testUser }}) {{ runner_folder }}
utils/ansible/configure-self-hosted-runner.yml
line 65 at r1 (raw file):
# Make sure the following environment variables are present in the env # to ensure propagation to the actions-runner environment.
Suggestion:
# Make sure the following environment variables are present in the env
# to ensure propagation to the actions-runner's environment.
utils/ansible/configure-self-hosted-runner.yml
line 70 at r1 (raw file):
path: "{{ runner_folder }}/env.sh" line: " 'PKG_CONFIG_PATH'\n 'HOME'" insertafter: "^varCheckList=\\("
Nothing major but squeezing these two lines into a single one made it harder for me to follow. Please consider using a loop instead.
Suggestion:
- name: "Add env variables into env.sh checklist"
lineinfile:
path: "{{ runner_folder }}/env.sh"
line: " '{{ item.line }}'"
insertafter: "^varCheckList=\\("
loop:
- line: PKG_CONFIG_PATH
- line: HOME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @szczepax)
a discussion (no related file):
Please prepend the commit message with the common:
prefix as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @szczepax)
Codecov Report
@@ Coverage Diff @@
## master #5816 +/- ##
==========================================
+ Coverage 70.93% 71.00% +0.07%
==========================================
Files 131 131
Lines 19175 19175
Branches 3192 3193 +1
==========================================
+ Hits 13602 13616 +14
+ Misses 5573 5559 -14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @szczepax)
a discussion (no related file):
Please squash all commits to a single one.
0414377
to
1973463
Compare
common: Update configure runner and opensuse setup scripts
1973463
to
b067ebb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @szczepax)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @szczepax)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @szczepax)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @szczepax)
This change is