Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: why Python-based tests are not used for package testing #5840

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Aug 5, 2023

Ref: #5839


This change is Reviewable

@janekmi janekmi added the sprint goal This pull request is part of the ongoing sprint label Aug 5, 2023
@janekmi janekmi added this to the 2.0.0 milestone Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #5840 (a5e2943) into master (ee3bb15) will increase coverage by 1.71%.
The diff coverage is n/a.

❗ Current head a5e2943 differs from pull request most recent head 7bae0f0. Consider uploading reports for the commit 7bae0f0 to get more accurate results

@@            Coverage Diff             @@
##           master    #5840      +/-   ##
==========================================
+ Coverage   69.29%   71.00%   +1.71%     
==========================================
  Files         131      131              
  Lines       19678    19175     -503     
  Branches     3259     3193      -66     
==========================================
- Hits        13636    13616      -20     
+ Misses       6042     5559     -483     

... package testing.

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi merged commit b814b7d into master Aug 7, 2023
5 checks passed
@janekmi janekmi deleted the packaging-python-tests branch August 8, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants