Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: use unofficial Coverity workflow #5859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 13 additions & 19 deletions .github/workflows/scan_coverity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,25 @@ on:
COVERITY_SCAN_TOKEN:
required: true

env:
GITHUB_REPO: pmem/pmdk
DOCKER_REPO: ghcr.io/pmem/pmdk
COVERITY_SCAN_NOTIFICATION_EMAIL: ${{ secrets.COVERITY_SCAN_NOTIFICATION_EMAIL }}
COVERITY_SCAN_TOKEN: ${{ secrets.COVERITY_SCAN_TOKEN }}
HOST_WORKDIR: /home/runner/work/pmdk/pmdk
WORKDIR: utils/docker
PMDK_CC: gcc
PMDK_CXX: g++
VALGRIND: 1
COVERITY: 1

jobs:
linux:
name: Linux
runs-on: ubuntu-latest
strategy:
matrix:
CONFIG: ["OS=ubuntu OS_VER=22.04"]
permissions:
contents: none
steps:
- name: Clone the git repo
uses: actions/checkout@v3

- name: Pull or rebuild the image
run: cd $WORKDIR && ${{ matrix.CONFIG }} ./pull-or-rebuild-image.sh
- name: Install dependencies
run: sudo apt-get -y install libndctl-dev libdaxctl-dev

- name: Skip building doc
run: touch .skip-doc

- name: Run the build
run: cd $WORKDIR && ${{ matrix.CONFIG }} ./build-CI.sh
- name: Coverity scan
uses: vapier/coverity-scan-action@v1
with:
email: ${{ secrets.COVERITY_SCAN_NOTIFICATION_EMAIL }}
token: ${{ secrets.COVERITY_SCAN_TOKEN }}
command: make -j all
3 changes: 0 additions & 3 deletions utils/docker/build-CI.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ containerName=pmdk-${OS}-${OS_VER}
if [[ $MAKE_PKG -eq 0 ]] ; then command="./run-build.sh"; fi
if [[ $MAKE_PKG -eq 1 ]] ; then command="./run-build-package.sh"; fi
if [[ $COVERAGE -eq 1 ]] ; then command="./run-coverage.sh"; fi
if [[ "$COVERITY" -eq 1 ]]; then command="./run-coverity.sh"; fi

if [ -n "$DNS_SERVER" ]; then DNS_SETTING=" --dns=$DNS_SERVER "; fi
if [[ -f $CI_FILE_SKIP_BUILD_PKG_CHECK ]]; then BUILD_PACKAGE_CHECK=n; else BUILD_PACKAGE_CHECK=y; fi
Expand Down Expand Up @@ -86,8 +85,6 @@ docker run --rm --name=$containerName -i \
--env CI_BRANCH=$CI_BRANCH \
--env CI_EVENT_TYPE=$CI_EVENT_TYPE \
--env DOC_UPDATE_GITHUB_TOKEN=$DOC_UPDATE_GITHUB_TOKEN \
--env COVERITY_SCAN_TOKEN=$COVERITY_SCAN_TOKEN \
--env COVERITY_SCAN_NOTIFICATION_EMAIL=$COVERITY_SCAN_NOTIFICATION_EMAIL \
--env FAULT_INJECTION=$FAULT_INJECTION \
--env GITHUB_ACTIONS=$GITHUB_ACTIONS \
--env GITHUB_HEAD_REF=$GITHUB_HEAD_REF \
Expand Down
4 changes: 0 additions & 4 deletions utils/docker/images/Dockerfile.ubuntu-22.04
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ ENV PACKAGING_DEPS "debhelper \
# Codecov (coverage measurement) dependencies (optional)
ENV CODECOV_DEPS curl perl

# Coverity (static analysis) dependencies (optional)
ENV COVERITY_DEPS ruby gcc g++ wget

# miscellaneous dependencies (mostly for CI)
ENV MISC_DEPS "clang \
hub \
Expand Down Expand Up @@ -98,7 +95,6 @@ RUN apt-get update && apt-get dist-upgrade -y \
$TESTS_DEPS \
$PACKAGING_DEPS \
$CODECOV_DEPS \
$COVERITY_DEPS \
$MISC_DEPS \
&& ./install-valgrind.sh ubuntu \
&& ./download-scripts.sh \
Expand Down
79 changes: 0 additions & 79 deletions utils/docker/run-coverity.sh

This file was deleted.

Loading