Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limited memmove with inline #5891

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Limited memmove with inline #5891

wants to merge 1 commit into from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Oct 24, 2023 •
edited
Loading

Decrease the amount of stack memory usage.
Remove inline attribute for complex memmove_mov_* functions.

Requires:

This change is Reviewable

@grom72 grom72 added DAOS DAOS-related sprint goal This pull request is part of the ongoing sprint labels Oct 24, 2023
@grom72 grom72 requested review from janekmi and osalyk October 24, 2023 09:40
@grom72 grom72 force-pushed the limited-memmove_ branch 2 times, most recently from 9129318 to b706201 Compare October 24, 2023 10:27
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #5891 (293a7a1) into master (a08e391) will increase coverage by 0.19%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 293a7a1 differs from pull request most recent head 78b74c1. Consider uploading reports for the commit 78b74c1 to get more accurate results

@@            Coverage Diff             @@
##           master    #5891      +/-   ##
==========================================
+ Coverage   71.00%   71.20%   +0.19%     
==========================================
  Files         131      131              
  Lines       19172    19307     +135     
  Branches     3192     3210      +18     
==========================================
+ Hits        13614    13748     +134     
- Misses       5558     5559       +1

@grom72 grom72 force-pushed the limited-memmove_ branch 4 times, most recently from 12aadcd to 749b513 Compare October 24, 2023 14:25
@grom72
common: reduce stack usage by eliminating complex memmove_ inline fun…
78b74c1 
…ction

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@janekmi janekmi removed the sprint goal This pull request is part of the ongoing sprint label Oct 31, 2023
@grom72 grom72 marked this pull request as draft November 8, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janekmi janekmi Awaiting requested review from janekmi

@osalyk osalyk Awaiting requested review from osalyk

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
DAOS DAOS-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grom72 @janekmi