common: fix support of OS_DIMM_CFLAG #5943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grom72
added
sprint goal
grom72
force-pushed
the
obsolete-OS_DIMM_CFLAG
branch
from
f17e607
to
1c45a5e
Compare
osalyk
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
grom72
force-pushed
the
obsolete-OS_DIMM_CFLAG
branch
from
1c45a5e
to
61c6c1a
Compare
`#if NDCTL_ENABLED` that is used in the source code expects that `NDCTL_ENABLED` is defined all the time with either *0* or *non-0* value. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
grom72
force-pushed
the
obsolete-OS_DIMM_CFLAG
branch
from
61c6c1a
to
0255347
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5943 +/- ##
==========================================
- Coverage 70.12% 70.12% -0.01%
==========================================
Files 133 133
Lines 19568 19568
Branches 3261 3261
==========================================
- Hits 13723 13722 -1
- Misses 5845 5846 +1 |
osalyk
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
janekmi
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#if NDCTL_ENABLEDthat is used in the source code expects thatNDCTL_ENABLEDis defined all the time with either 0 or non-0 value.This change is