Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: add upload step to the stack usage scan #5989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

common: add upload step to the stack usage scan #5989

wants to merge 1 commit into from

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Jan 30, 2024 •
edited
Loading

@janekmi janekmi added the no changelog Add to skip the changelog check on your pull request label Jan 30, 2024
@janekmi janekmi requested a review from grom72 January 30, 2024 00:22
@janekmi
common: add upload step to the stack usage scan
1ec6543 
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
grom72
grom72 requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

a discussion (no related file):
The only problem I see is that when you open the workflow, GitHub jumps to an invalid location of error.

grom72
grom72 requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

The only problem I see is that when you open the workflow, GitHub jumps to an invalid location of error.

Shall we also print not_called.json directly to GHA log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grom72 grom72 grom72 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
no changelog Add to skip the changelog check on your pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janekmi @grom72