common: introduce logging level HARK

[grom72]

CORE_LOG_HARK together with CORE_LOG_LEVEL_HARK are used for messages that should always be visible in the logging system like library version number, Valgrind compilation status and other basic library information.

---

This change is 

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8ff6a12) 70.06% compared to head (2acd889) 70.03%.

❗ Current head 2acd889 differs from pull request most recent head 2836433. Consider uploading reports for the commit 2836433 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6020      +/-   ##
==========================================
- Coverage   70.06%   70.03%   -0.03%     
==========================================
  Files         133      133              
  Lines       19570    19562       -8     
  Branches     3266     3263       -3     
==========================================
- Hits        13711    13701      -10     
- Misses       5859     5861       +2     

[janekmi]

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @grom72)

---

src/core/log_default.c line 42 at r1 (raw file):

	[CORE_LOG_LEVEL_NOTICE]		= LOG_NOTICE,
	[CORE_LOG_LEVEL_INFO]		= LOG_INFO,
	[CORE_LOG_LEVEL_DEBUG]		= LOG_DEBUG,

I prefer to keep indices in order.

Suggestion:

	[CORE_LOG_LEVEL_HARK]		= LOG_NOTICE,
	[CORE_LOG_LEVEL_FATAL]		= LOG_CRIT,
	[CORE_LOG_LEVEL_ERROR]		= LOG_ERR,
	[CORE_LOG_LEVEL_WARNING]	= LOG_WARNING,
	[CORE_LOG_LEVEL_NOTICE]		= LOG_NOTICE,
	[CORE_LOG_LEVEL_INFO]		= LOG_INFO,
	[CORE_LOG_LEVEL_DEBUG]		= LOG_DEBUG,

---

src/core/log_internal.h line 25 at r1 (raw file):

enum core_log_level {
	/* all messages will be suppressed except basic library info */

The reference to suppression seems out of place. It is just a level as any other.

Suggestion:

only basic library info

---

src/include/libpmemobj/log.h line 21 at r1 (raw file):

 */
enum pmemobj_log_level {
	/* all messages will be suppressed except basic library info */

.

---

src/include/libpmemobj/log.h line 90 at r1 (raw file):

 *
 * Available threshold levels are defined by enum log_level:
 * - PMEMOBJ_LOG_LEVEL_HARK - all messages will be suppressed except lib info

.

[grom72]

Reviewable status: 12 of 15 files reviewed, 4 unresolved discussions (waiting on @janekmi)

---

src/core/log_default.c line 42 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I prefer to keep indices in order.

Done.

---

src/core/log_internal.h line 25 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

The reference to suppression seems out of place. It is just a level as any other.

Done.

---

src/include/libpmemobj/log.h line 21 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

Done.

---

src/include/libpmemobj/log.h line 90 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

Done.

[janekmi]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)