common: missing header file stdarg.h added #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file originally has been included in out.h, and is no longer there after new core_log impelmentation. In majority of builds it was included via valgrind.h, but it is not valid for builds with `make EXTRA_CFLAGS=-DVG_MEMCHECK_ENABLED=0` Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
grom72
added
sprint goal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6027 +/- ##
==========================================
- Coverage 70.05% 70.04% -0.02%
==========================================
Files 133 133
Lines 19564 19564
Branches 3263 3263
==========================================
- Hits 13705 13703 -2
- Misses 5859 5861 +2 |
janekmi
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file originally has been included in
out.h,and is no longer there after the new core_log implementation.
In the majority of builds it was included via
valgrind.h,but it is not valid for builds withmake EXTRA_CFLAGS=-DVG_MEMCHECK_ENABLED=0This change is