Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip run tests for static builds #6034

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Mar 1, 2024

To avoid problems with unneeded unit tests run with static builds.
https://github.com/pmem/pmdk/actions/runs/8100652684/job/22139139713#step:4:1422


This change is Reviewable

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 added the no changelog Add to skip the changelog check on your pull request label Mar 1, 2024
@grom72 grom72 requested a review from janekmi March 1, 2024 13:46
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (4f686a8) to head (106675c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6034      +/-   ##
==========================================
- Coverage   70.06%   70.04%   -0.02%     
==========================================
  Files         133      133              
  Lines       19563    19563              
  Branches     3263     3263              
==========================================
- Hits        13706    13703       -3     
- Misses       5857     5860       +3     

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit ad17ad3 into pmem:master Mar 1, 2024
8 checks passed
@grom72 grom72 deleted the skip-static-build-in-ut branch March 11, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants