Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: core_log_set/get_threshold MT unit tests #6035

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Mar 4, 2024

This change is Reviewable

@janekmi janekmi added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Mar 4, 2024
@janekmi janekmi requested review from grom72 and osalyk March 4, 2024 21:55
Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @grom72 and @osalyk)

a discussion (no related file):
Having two implementations is pointless. Since ATOMIC_OPERATIONS_SUPPORTED is not properly detected in the build system and effectively conflicting with the existing implementation of util_atomic_store/load() which is not out-of-the-box understood by Helgirnd/DRD, I decided to stick to the existing __sync_bool_compare_and_swap() implementation.

The chosen implementation is properly handled by Valgrind tools making testing just easy.


Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (ad17ad3) to head (3e5569d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6035      +/-   ##
==========================================
- Coverage   70.05%   70.04%   -0.02%     
==========================================
  Files         133      133              
  Lines       19563    19563              
  Branches     3263     3262       -1     
==========================================
- Hits        13704    13702       -2     
- Misses       5859     5861       +2     

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)


src/test/Makefile line 113 at r1 (raw file):

	core_log_internal\
	core_log_max\
	core_log_mt\

Do we want to keep all MT tests in one folder or shall we rename this folder to core_log_threshold_mt?

Code quote:

core_log_mt

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi merged commit 2edad18 into pmem:master Mar 6, 2024
8 checks passed
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 6, 2024
- make core_log_set_threshold() robust to EAGAIN
- make core_log_threshold_mt a dedicated test
- add threads attempting to call CORE_LOG_X() in parallel

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 6, 2024
- make core_log_set_threshold() robust to EAGAIN
- make core_log_threshold_mt a dedicated test
- add threads attempting to call CORE_LOG_X() in parallel

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 6, 2024
- make core_log_set_threshold() robust to EAGAIN
- make core_log_threshold_mt a dedicated test
- add threads attempting to call CORE_LOG_X() in parallel

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 6, 2024
- make core_log_set_threshold() robust to EAGAIN
- make core_log_threshold_mt a dedicated test
- add threads attempting to call CORE_LOG_X() in parallel

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 6, 2024
- make core_log_set_threshold() robust to EAGAIN
- make core_log_threshold_mt a dedicated test
- add threads attempting to call CORE_LOG_X() in parallel

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 7, 2024
- make core_log_set_threshold() robust to EAGAIN
- make core_log_threshold_mt a dedicated test
- add threads attempting to call CORE_LOG_X() in parallel

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 7, 2024
- make core_log_threshold_mt a dedicated test
- keep Core_log_threshold available only via API
- add _core_log_get_threshold_internal() calls

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 7, 2024
- make core_log_threshold_mt a dedicated test
- keep Core_log_threshold available only via API
- add _core_log_get_threshold_internal() calls

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 7, 2024
- make core_log_threshold_mt a dedicated test
- keep Core_log_threshold available only via API
- add _core_log_get_threshold_internal() calls

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 7, 2024
- make core_log_threshold_mt a dedicated test
- keep Core_log_threshold available only via API
- add _core_log_get_threshold_internal() calls

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
janekmi added a commit to janekmi/pmdk that referenced this pull request Mar 7, 2024
- make core_log_threshold_mt a dedicated test
- keep Core_log_threshold available only via API
- add _core_log_get_threshold_internal() calls

Ref: pmem#6035

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants