-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: drop the logging context #6037
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6037 +/- ##
=======================================
Coverage 70.08% 70.09%
=======================================
Files 133 133
Lines 19563 19557 -6
Branches 3262 3261 -1
=======================================
- Hits 13711 13708 -3
+ Misses 5852 5849 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)
src/include/libpmemobj/log.h
line 195 at r1 (raw file):
* log_function is PMEMOBJ_LOG_USE_DEFAULT_FUNCTION the provided context is * ignored. *
Suggestion:
* DESCRIPTION
* pmemobj_log_set_function() allows choosing the function which will get all
* the generated logging messages. The log_function can be either
* PMEMOBJ_LOG_USE_DEFAULT_FUNCTION which will use the default logging function
* (built into the library) or a pointer to a user-defined function.
*
src/test/core_log_no_func/core_log_no_func
line 0 at r1 (raw file):
Why do we have this file here?
47adba1
to
1cd585f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 12 of 13 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)
src/include/libpmemobj/log.h
line 195 at r1 (raw file):
* log_function is PMEMOBJ_LOG_USE_DEFAULT_FUNCTION the provided context is * ignored. *
Done.
src/test/core_log_no_func/core_log_no_func
line at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Why do we have this file here?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 13 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)
1cd585f
to
f3aedaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r3, all commit messages.
Reviewable status: 11 of 14 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 13 files at r1, 2 of 4 files at r3.
Reviewable status: 13 of 14 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)
f3aedaf
to
def6b52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2, 4 of 4 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
This change is