Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: drop the logging context #6037

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Mar 6, 2024

This change is Reviewable

@janekmi janekmi added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Mar 6, 2024
@janekmi janekmi requested review from grom72 and osalyk March 6, 2024 11:26
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (bf09701) to head (def6b52).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6037   +/-   ##
=======================================
  Coverage   70.08%   70.09%           
=======================================
  Files         133      133           
  Lines       19563    19557    -6     
  Branches     3262     3261    -1     
=======================================
- Hits        13711    13708    -3     
+ Misses       5852     5849    -3     

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)


src/include/libpmemobj/log.h line 195 at r1 (raw file):

 * log_function is PMEMOBJ_LOG_USE_DEFAULT_FUNCTION the provided context is
 * ignored.
 *

Suggestion:

 * DESCRIPTION
 * pmemobj_log_set_function() allows choosing the function which will get all
 * the generated logging messages. The log_function can be either
 * PMEMOBJ_LOG_USE_DEFAULT_FUNCTION which will use the default logging function
 * (built into the library) or a pointer to a user-defined function.
 *

src/test/core_log_no_func/core_log_no_func line 0 at r1 (raw file):
Why do we have this file here?

Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 12 of 13 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)


src/include/libpmemobj/log.h line 195 at r1 (raw file):

 * log_function is PMEMOBJ_LOG_USE_DEFAULT_FUNCTION the provided context is
 * ignored.
 *

Done.


src/test/core_log_no_func/core_log_no_func line at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Why do we have this file here?

Done.

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 13 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)

Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r3, all commit messages.
Reviewable status: 11 of 14 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)

Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 13 files at r1, 2 of 4 files at r3.
Reviewable status: 13 of 14 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)

Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r2, 4 of 4 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi merged commit 5a10cba into pmem:master Mar 7, 2024
8 checks passed
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants