-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip core_log_default_function tests for static builds #6042
test: skip core_log_default_function tests for static builds #6042
Conversation
b9f2b7d
to
39c1892
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
src/test/core_log_default_function/TESTS.py
line 13 at r1 (raw file):
@g.require_granularity(g.ANY) # No dynamic libraries are used nor .static_* builds are available. @t.require_build(['debug','nondebug'])
Please correct.
Suggestion:
@t.require_build(['debug', 'nondebug'])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)
src/test/core_log_default_function/TESTS.py
line 13 at r1 (raw file):
@g.require_granularity(g.ANY) # No dynamic libraries are used nor .static_* builds are available. @t.require_build(['debug','nondebug'])
What is the difference between debug and nondebug run for this particular unit test since no dynamic libraries are used?
Code quote:
@t.require_build(['debug','nondebug'])
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
39c1892
to
cad5819
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)
src/test/core_log_default_function/TESTS.py
line 13 at r1 (raw file):
Previously, osalyk (Oksana Sałyk) wrote…
Please correct.
Done.
src/test/core_log_default_function/TESTS.py
line 13 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
What is the difference between debug and nondebug run for this particular unit test since no dynamic libraries are used?
Done.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6042 +/- ##
==========================================
- Coverage 70.09% 70.09% -0.01%
==========================================
Files 133 133
Lines 19560 19560
Branches 3261 3261
==========================================
- Hits 13711 13710 -1
- Misses 5849 5850 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)
https://github.com/pmem/pmdk/actions/runs/8176759291/job/22356890387#step:4:3092
This change is