Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip core_log_default_function tests for static builds #6042

Merged

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Mar 8, 2024

@grom72 grom72 added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Mar 8, 2024
@grom72 grom72 requested review from janekmi and osalyk March 8, 2024 07:38
@grom72 grom72 force-pushed the core_log_default_function-only-in-non-static branch from b9f2b7d to 39c1892 Compare March 8, 2024 07:38
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)


src/test/core_log_default_function/TESTS.py line 13 at r1 (raw file):

@g.require_granularity(g.ANY)
# No dynamic libraries are used nor .static_* builds are available.
@t.require_build(['debug','nondebug'])

Please correct.

Suggestion:

@t.require_build(['debug', 'nondebug'])

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)


src/test/core_log_default_function/TESTS.py line 13 at r1 (raw file):

@g.require_granularity(g.ANY)
# No dynamic libraries are used nor .static_* builds are available.
@t.require_build(['debug','nondebug'])

What is the difference between debug and nondebug run for this particular unit test since no dynamic libraries are used?

Code quote:

@t.require_build(['debug','nondebug'])

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 force-pushed the core_log_default_function-only-in-non-static branch from 39c1892 to cad5819 Compare March 8, 2024 13:59
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)


src/test/core_log_default_function/TESTS.py line 13 at r1 (raw file):

Previously, osalyk (Oksana Sałyk) wrote…

Please correct.

Done.


src/test/core_log_default_function/TESTS.py line 13 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

What is the difference between debug and nondebug run for this particular unit test since no dynamic libraries are used?

Done.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (e06c162) to head (cad5819).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6042      +/-   ##
==========================================
- Coverage   70.09%   70.09%   -0.01%     
==========================================
  Files         133      133              
  Lines       19560    19560              
  Branches     3261     3261              
==========================================
- Hits        13711    13710       -1     
- Misses       5849     5850       +1     

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

@janekmi janekmi merged commit bbf9c4f into pmem:master Mar 8, 2024
7 of 8 checks passed
@grom72 grom72 deleted the core_log_default_function-only-in-non-static branch March 11, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants