Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: various clang fixes #6045

Merged
merged 3 commits into from
Mar 12, 2024
Merged

common: various clang fixes #6045

merged 3 commits into from
Mar 12, 2024

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Mar 11, 2024

This change is Reviewable

@janekmi janekmi added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Mar 11, 2024
@janekmi janekmi requested review from grom72 and osalyk March 11, 2024 08:26
@janekmi janekmi force-pushed the workflow-additions branch 2 times, most recently from 1b415d8 to c8b6fea Compare March 11, 2024 08:34
@janekmi janekmi changed the title common: add parallel clang Main / Basic build common: add parallel clang Main / Basic build (WIP) Mar 11, 2024
@janekmi janekmi changed the title common: add parallel clang Main / Basic build (WIP) common: various clang fixes Mar 11, 2024
@janekmi janekmi force-pushed the workflow-additions branch 2 times, most recently from 6abce3b to eb5bec0 Compare March 11, 2024 17:59
Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 5 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72 and @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 5 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 5 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (b00e032) to head (eb5bec0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6045      +/-   ##
==========================================
- Coverage   70.09%   70.08%   -0.01%     
==========================================
  Files         133      133              
  Lines       19560    19560              
  Branches     3261     3261              
==========================================
- Hits        13710    13709       -1     
- Misses       5850     5851       +1     

@janekmi janekmi merged commit 396c967 into pmem:master Mar 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants