Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: update actions/checkout to v4 #6046

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Mar 11, 2024

It seems the only thing changed between v3 and v4 is node20. v4.1.1 has been used in our ci before. It was unified to directly use v4 which will make our life easier since we would not need to update these workflows till v5.

Ref: https://github.com/actions/checkout/releases/tag/v4.0.0


This change is Reviewable

@janekmi janekmi added the no changelog Add to skip the changelog check on your pull request label Mar 11, 2024
@janekmi janekmi requested review from grom72 and osalyk March 11, 2024 10:38
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 16 files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

It seems the only thing changed between v3 and v4 is node20.
v4.1.1 has been used in our ci before. It was unified
to directly use v4 which will make our life easier since
we would not need to update these workflows till v5.

Ref: https://github.com/actions/checkout/releases/tag/v4.0.0

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
@janekmi janekmi added the sprint goal This pull request is part of the ongoing sprint label Mar 11, 2024
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi merged commit 9819db6 into pmem:master Mar 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants