test: UT for core_log_set_function()

[grom72]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (9819db6) to head (9a96de0).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6047   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files         133      133           
  Lines       19563    19563           
  Branches     3261     3261           
=======================================
+ Hits        13708    13709    +1     
+ Misses       5855     5854    -1     

[janekmi]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @grom72 and @osalyk)

---

src/test/core_log/core_log.c line 206 at r1 (raw file):

/* Happy day scenario with custom logging function */
static int
test_set_custom_function(const struct test_case *tc, int argc, char *argv[])

This function is basically a copy of the test_happy_day() function. I recommend establishing test_happy_day_helper() with appropriate if-else statements allowing testing both test_happy_day and test_set_custom_function.

Code quote:

test_set_custom_function

---

src/test/core_log/core_log.c line 214 at r1 (raw file):

	 * disable MOCK as custom_log_function() may be called form
	 * core_log_set_function()
	 */

Suggestion:

	/*
	 * Disable the validation as custom_log_function() may be called form
	 * core_log_set_function().
	 */

---

src/test/core_log/core_log.c line 215 at r1 (raw file):

	 * core_log_set_function()
	 */
	FUNC_MOCK_RCOUNTER_SET(custom_log_function, 0);

Suggestion:

#define NOT_VALIDATED_CALL 0

FUNC_MOCK_RCOUNTER_SET(custom_log_function, NOT_VALIDATED_CALL);

---

src/test/core_log/core_log_common.c line 86 at r1 (raw file):

FUNC_MOCK_END

/* custom logging function MOCK used only in test_set_custom_function test */

I don't like this comment. Not much value and even less maintainability.

[grom72]

Reviewable status: 1 of 4 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)

---

src/test/core_log/core_log.c line 214 at r1 (raw file):

	 * disable MOCK as custom_log_function() may be called form
	 * core_log_set_function()
	 */

Done.

---

src/test/core_log/core_log.c line 215 at r1 (raw file):

	 * core_log_set_function()
	 */
	FUNC_MOCK_RCOUNTER_SET(custom_log_function, 0);

Done.

---

src/test/core_log/core_log_common.c line 86 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I don't like this comment. Not much value and even less maintainability.

Done.

[janekmi]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

[osalyk]

Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

[osalyk]

Reviewed 2 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)