common: allow check_license to apply proposed changes #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janekmi
added
sprint goal
janekmi
force-pushed
the
check-license-1.1
branch
5 times, most recently
from
5eb6ffe
to
c045462
Compare
janekmi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6058 +/- ##
=======================================
Coverage 70.11% 70.11%
=======================================
Files 133 133
Lines 19560 19560
Branches 3261 3261
=======================================
+ Hits 13714 13715 +1
+ Misses 5846 5845 -1 |
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
- assuming the source is not dirty Signed-off-by: Jan Michalski <jan.michalski@intel.com>
osalyk
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
grom72
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status:
grom72
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
This change is