doc: add pmem_log_* documentations #6061
Conversation
osalyk
added
sprint goal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6061 +/- ##
==========================================
- Coverage 70.14% 70.12% -0.02%
==========================================
Files 133 133
Lines 19568 19568
Branches 3261 3261
==========================================
- Hits 13726 13723 -3
- Misses 5842 5845 +3 |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
doc/libpmem/pmem_log_set_function.3.md line 37 at r1 (raw file):
enum pmem_log_level level, const char *file_name, const int line_no,
According to the latest status ...
Suggestion:
unsigned line_no
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
doc/libpmem/pmem_log_set_function.3.md line 37 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
According to the latest status ...
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)
doc/libpmem/pmem_log_set_threshold.3.md line 78 at r2 (raw file):
- **PMEM_LOG_LEVEL_FATAL** - an error that causes the program to stop working immediately. Sorry. - **PMEM_LOG_LEVEL_ERROR** - an error that causes the current operation or transaction to fail
Suggestion:
an error that causes the current operation to fail
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
doc/libpmem/pmem_log_set_threshold.3.md line 78 at r2 (raw file):
- **PMEM_LOG_LEVEL_FATAL** - an error that causes the program to stop working immediately. Sorry. - **PMEM_LOG_LEVEL_ERROR** - an error that causes the current operation or transaction to fail
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
This change is