Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: suppress ERROR messages when irrelevant to the test result #6063

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Mar 20, 2024

Suppress *ERROR* messages from stderr in tests that verify faulty situations based on function return value and errno value. These tests ignore stderr/stdout at all.
This is to avoid a lot of unnecessary messages on the screen during test execution.


This change is Reviewable

@grom72 grom72 added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Mar 20, 2024
@grom72 grom72 requested review from osalyk and janekmi March 20, 2024 14:54
Suppress *ERROR* messages from stderr in tests that verify faulty
situation based on function return value and errno value.
These tests ignore stderr/stdout at all.
This is to avoid a lot of unnecessary messages on the screen during
tests execution.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 changed the title test: suppress ERROR messages when irrelevant for test result test: suppress ERROR messages when irrelevant to the test result Mar 20, 2024
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@grom72 grom72 added this to the 2.1.1 milestone Mar 27, 2024
@janekmi janekmi modified the milestones: 2.1.1, 2.1.0 Mar 27, 2024
@grom72 grom72 modified the milestones: 2.1.0, 2.x Mar 28, 2024
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit 6302d16 into pmem:master Mar 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants