-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obj: unify description with implementation pmemobj_log* fun #6067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6067 +/- ##
==========================================
- Coverage 70.12% 70.12% -0.01%
==========================================
Files 133 133
Lines 19568 19568
Branches 3261 3261
==========================================
- Hits 13723 13722 -1
- Misses 5845 5846 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)
src/include/libpmemobj/log.h
line 25 at r1 (raw file):
/* an error that causes the program to stop working immediately */ PMEMOBJ_LOG_LEVEL_FATAL, /* an error that causes the current operation to fail */
Suggestion:
/* an error that causes the current operation or transaction to fail */
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
src/include/libpmemobj/log.h
line 25 at r1 (raw file):
/* an error that causes the program to stop working immediately */ PMEMOBJ_LOG_LEVEL_FATAL, /* an error that causes the current operation to fail */
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
This change is