Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing doc file #6073

Merged
merged 1 commit into from
Apr 8, 2024
Merged

doc: add missing doc file #6073

merged 1 commit into from
Apr 8, 2024

Conversation

osalyk
Copy link
Contributor

@osalyk osalyk commented Apr 4, 2024

@osalyk osalyk added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Apr 4, 2024
@osalyk osalyk requested review from grom72 and janekmi April 4, 2024 07:36
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (e798397) to head (59a2b06).

❗ Current head 59a2b06 differs from pull request most recent head c45d8c9. Consider uploading reports for the commit c45d8c9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6073      +/-   ##
==========================================
- Coverage   70.13%   70.12%   -0.01%     
==========================================
  Files         133      133              
  Lines       19568    19568              
  Branches     3261     3261              
==========================================
- Hits        13724    13723       -1     
- Misses       5844     5845       +1     

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)


doc/Makefile line 35 at r1 (raw file):

		   libpmem/pmem_memcpy.3 libpmem/pmem_memset.3 libpmem/pmem_memmove.3 \
		   libpmem/pmem_check_version.3 libpmem/pmem_errormsg.3 \
		   libpmem/pmem_log_use_default_function.3 \

You ought to add this file instead of removing it from this list. Exactly as it has been done for libpmemobj/pmemobj_log_use_default_function.3.

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)


doc/Makefile line 35 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

You ought to add this file instead of removing it from this list. Exactly as it has been done for libpmemobj/pmemobj_log_use_default_function.3.

Done.

@osalyk osalyk changed the title doc: remove unnecessary line doc: add missing doc file Apr 8, 2024
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@janekmi janekmi requested a review from grom72 April 8, 2024 07:31
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@janekmi janekmi merged commit d38a0a0 into pmem:master Apr 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants