Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: add SDS related CORE_LOG_WARNING to core_log_max test #6075

Merged
merged 1 commit into from
Apr 15, 2024
Merged

common: add SDS related CORE_LOG_WARNING to core_log_max test #6075

merged 1 commit into from
Apr 15, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Apr 9, 2024 •
edited
Loading

This change is Reviewable

@grom72 grom72 added the no changelog Add to skip the changelog check on your pull request label Apr 9, 2024
@grom72 grom72 added this to the 2.1.0 milestone Apr 9, 2024
@grom72 grom72 requested review from janekmi and osalyk April 9, 2024 18:05
@grom72
common: add SDS related CORE_LOG_WARNING to core_log_max test
a47b754 
Signed-off-by: Gromadzki, Tomasz <tomasz.gromadzki@intel.com>
janekmi
janekmi approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@grom72 grom72 added sprint goal This pull request is part of the ongoing sprint and removed Priority: 1 urgent labels Apr 11, 2024
osalyk
osalyk approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit b46342e into pmem:master Apr 15, 2024
6 of 7 checks passed
@grom72 grom72 deleted the SDS-fix-1 branch May 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osalyk osalyk osalyk approved these changes

@janekmi janekmi janekmi approved these changes

Assignees
No one assigned
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grom72 @janekmi @osalyk