common: update CODECOV workflow file

[osalyk]

This change is 

[janekmi]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)

---

.github/workflows/scan_coverage.yml line 26 at r1 (raw file):

  TEST_BUILD:   debug
  FAULT_INJECTION: 1
  CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

I believe it is no longer necessary to be available as an environment variable since the run-coverage.sh script does not do an upload any more.

---

.github/workflows/scan_coverage.yml line 47 at r1 (raw file):

          root_dir: /home/runner/work/pmdk/pmdk/
          directory: /home/runner/work/pmdk/pmdk/
          verbose: true

I prefer to pass it explicitly instead of as an env. It is an unusual feature for an action and it is hard to track where the token comes from in this case.

Suggestion:

          token: ${{ secrets.CODECOV_TOKEN }}
          verbose: true

---

utils/docker/run-coverage.sh line 37 at r1 (raw file):

# prepare flag for codecov report to differentiate builds
flag=tests
[ -n "${GITHUB_ACTIONS}" ] && flag=GHA

It is not consumed anymore so no point in setting it here.

[osalyk]

Reviewable status: 4 of 6 files reviewed, 3 unresolved discussions (waiting on @janekmi)

---

.github/workflows/scan_coverage.yml line 26 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I believe it is no longer necessary to be available as an environment variable since the run-coverage.sh script does not do an upload any more.

Done.

---

.github/workflows/scan_coverage.yml line 47 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I prefer to pass it explicitly instead of as an env. It is an unusual feature for an action and it is hard to track where the token comes from in this case.

Done.

---

utils/docker/run-coverage.sh line 37 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

It is not consumed anymore so no point in setting it here.

Done.

[grom72]

Reviewed 4 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @janekmi)

[janekmi]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)