Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.1.0 #6085

Merged
merged 280 commits into from
May 13, 2024
Merged

Release 2.1.0 #6085

merged 280 commits into from
May 13, 2024

Conversation

osalyk
Copy link
Contributor

@osalyk osalyk commented May 10, 2024 •
edited by grom72
Loading

This change is Reviewable

janekmi and others added 30 commits January 25, 2024 10:50
@janekmi
Merge pull request pmem#5969 from grom72/never-skip-usc-check-on-pmem
25e363d 
common: does not allow open pmem w/o USC
@grom72
common: Removing the annoying test directory suffix
c2db02a 
Removing the Braille test directory suffix to simplify
manual test reproduction.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@janekmi
Merge pull request pmem#5977 from grom72/no-braille-sufix-in-tests
6ee3f36 
common: Removing the annoying test directory suffix
@grom72
common: replace ERR("!...", ... ) by ERR_W_ERRNO(...)
4f9cf63 
ERR() macro uses CORE_LOG_ERROR to push mesages to ouputs
Introduce to separate macros to report errors w/ and w/o errno.
test for CORE_LOG_ERROR_WITH_ERRNO

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
test: suppress CORE_LOG_ERROR() messages in some pmempool tests
a224c73 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: disable obj_tx_add_range until issue pmem#5972 is fixed
efdbc71 
Disable test until issue pmem#5972 is fixed.
pmem#5972

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: disable obj_tx_add_range_direct until issue pmem#5974 is fixed
fa78192 
Disable test until issue pmem#5974 is fixed.
pmem#5974

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
pmem: disable flag verification until pmem#5979 is fixed
ac4f3c9 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@janekmi
Merge pull request pmem#5965 from grom72/common-log-error-w-errno
0153692 
Replace ERR("!... ") with ERR_W_ERRNO
@janekmi
Merge pull request pmem#5980 from grom72/disable-5979
069c860 
pmem: disable flag verification until pmem#5979 is fixed
@grom72
common: replace ERR("...", ... ) by ERR_WO_ERRNO(...)
c7b4085 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: exclude error messages in examples tests
7576c09 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: include new ERROR messages in match files
65ad2bd 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: exclude error messages in pmempool_sync tests until pmem#5983 …
a2d9fcd 
…fixed

pmem#5983

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: disable pmempool_transform tests unitl issue pmem#5982 is fixed
dd220a9 
pmem#5982

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: exclude error messages in pmempool_transform tests
ac7b315 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: fartially disable libpmempool_featuretests unitl pmem#5981 is…
35f64bc 
… fixed

pmem#5981

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: add out_log_va to white list
a465cfc 
Add out_log_va to the white list as it is no longer used in the
release version.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: include ERROR message in pmempool_feature tests
6d09ac2 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: errno explicitly provided to ERR() macro.
6a9fea9 
Remove "!..." logic from error message format string.
Use separate argument to either use or not use errno in error message.
Remove non-posix version of util_strerror.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@janekmi
Merge pull request pmem#5966 from grom72/common-log-error-wo-errno
197782c 
Replace ERR() by ERR_WO_ERRNO
@janekmi
Merge pull request pmem#5976 from grom72/ERR-w-explicit-errno
87d34cf 
err() with explicit errno
@grom72
obj: all errorl logs via ERR_WO_ERRNO()
4f3473f 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Merge pull request pmem#5967 from grom72/pmemobj-error-via-ERR
caa911e 
Pmemobj error via ERR() instead of LOG(1,...
@janekmi
Merge pull request pmem#5986 from grom72/call-stack-analysis-whitelist
97de0a8 
common: add out_log_va to white list
@janekmi
common: final touch for the default logging function
496812b 
- put the primary destination first and the auxiliary second

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
@grom72
common: introduce a separate FATAL macro with errno
3a71c49 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: replace FATAL* by CORE_LOG_FATAL*
c64c0c9 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: remove old FATAL implementation
f9df201 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
common: assert macros redefinition
5eb4adc 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
osalyk and others added 11 commits April 15, 2024 08:03
@osalyk
doc: remove unneeded file
4637992
@janekmi
Merge pull request pmem#6075 from grom72/SDS-fix-1
b46342e 
common: add SDS related CORE_LOG_WARNING to core_log_max test
@janekmi
Merge pull request pmem#6076 from pmem/doc_fail
2ef62c4 
doc: remove unneeded file
@osalyk
utils: change lower_limit
a8b1cc6 
The problem was observed and confirmed only on Ubuntu
@grom72
Merge pull request pmem#6078 from pmem/stack_usage_limit
3a208d6 
utils: change lower_limit
@grom72
doc: logging information added to manpages (7)
0c3223e 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.co
@janekmi
Merge pull request pmem#6083 from grom72/logging7md
c832d31 
doc: logging information added to manpages (7)
@osalyk
doc: mark old logging as deprecated
4f27651
@janekmi
Merge pull request pmem#6082 from osalyk/logging_deprecated
ff78d98 
doc: mark old logging as deprecated
@osalyk
common: update CODECOV workflow file
b003aae
@janekmi
Merge pull request pmem#6084 from pmem/codecov_build
88db614 
common: update CODECOV workflow file
@osalyk osalyk added the sprint goal This pull request is part of the ongoing sprint label May 10, 2024
@osalyk osalyk requested review from grom72 and janekmi May 10, 2024 11:01
janekmi
janekmi approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

grom72
grom72 requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

ChangeLog line 6 at r2 (raw file):


	This release:
	- ...

It is not needed in the release Changelog or at least it should be a part of the second commit

osalyk
osalyk commented May 10, 2024
View reviewed changes
Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

ChangeLog line 6 at r2 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

It is not needed in the release Changelog or at least it should be a part of the second commit

You need to prepare space for future releases. I think it should stay here in order not to make another PR later on.

grom72
grom72 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

grom72
grom72 requested changes May 12, 2024
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_cancel:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

a discussion (no related file):
Rename the target branch to stable-2.1

@osalyk osalyk changed the base branch from stable-2.1.0 to stable-2.1 May 13, 2024 06:58
osalyk
osalyk commented May 13, 2024
View reviewed changes
Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Rename the target branch to stable-2.1

Done.

grom72
grom72 requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @osalyk)

a discussion (no related file):

Previously, osalyk (Oksana Sałyk) wrote…

Done.

@osalyk please remove branch stable-2.1.0

a discussion (no related file):
Shall we also modify utils/docker/images/set-images-version.sh?

osalyk
osalyk commented May 13, 2024
View reviewed changes
Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 370 files reviewed, 2 unresolved discussions (waiting on @grom72 and @janekmi)

a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

@osalyk please remove branch stable-2.1.0

Done.

a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Shall we also modify utils/docker/images/set-images-version.sh?

Done.

grom72
grom72 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 366 of 366 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

grom72
grom72 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@grom72 grom72 merged commit cd4ad2d into pmem:stable-2.1 May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janekmi janekmi janekmi approved these changes

@grom72 grom72 grom72 approved these changes

Assignees
No one assigned
Labels
sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osalyk @grom72 @janekmi