-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: remove pmem.io workflow file and related #6089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)
doc/README
line 9 at r1 (raw file):
If you're looking for documentation to get you started using PMDK, start here: https://github.com/pmem/pmdk. Developers new to PMDK are probably looking for libpmemobj.
I think we should leave the reference to pmem.io/pmdk as we do not have any other general documentation about PMDK
Code quote:
get you started using PMDK, start here: https://github.com/pmem/pmdk.
Developers new to PMDK are probably looking for libpmemobj.
src/examples/README
line 31 at r1 (raw file):
libpmem2(7) -- low-level persistent memory support Example programs are in the libpmem2 directory. More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmem2
Examples' documentation on pmem.io is OK (we do not have an alternative).
Code quote:
If you're looking for documentation to get you started using PMDK,
start here: https://github.com/pmem/pmdk and follow the links to examples and
man pages. Developers new to PMDK are probably looking for libpmemobj.
Many of the examples in this directory are described in more detail
on the above web site.
libpmem(7) -- low-level persistent memory support
Example programs are in the libpmem directory.
More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmem
libpmemobj(7) -- transactional object store
Example programs are in the libpmemobj directory.
More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmemobj
libpmempool(7) -- pool management, diagnostics and repair
Example programs are in the libpmempool directory.
More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmempool
libpmem2(7) -- low-level persistent memory support
Example programs are in the libpmem2 directory.
More documentation: https://github.com/pmem/pmdk/tree/master/src/libpmem2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 11 of 14 files reviewed, 2 unresolved discussions (waiting on @grom72 and @janekmi)
doc/README
line 9 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
I think we should leave the reference to pmem.io/pmdk as we do not have any other general documentation about PMDK
Done.
src/examples/README
line 31 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Examples' documentation on pmem.io is OK (we do not have an alternative).
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 14 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
This change is