-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: fix typo in pmem_tests.yml file #6104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
a discussion (no related file):
Can we also fix the pmem_test_prepare
action with the following checker:
- run: |
[[ "${{ inputs.valgrind}}" ]] || { echo "valgrind input is empty" ; exit 1; }
97df90f
to
d566450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
a discussion (no related file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Can we also fix the
pmem_test_prepare
action with the following checker:- run: | [[ "${{ inputs.valgrind}}" ]] || { echo "valgrind input is empty" ; exit 1; }
https://github.com/pmem/pmdk/actions/runs/10108819271/job/27955490804
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
.github/actions/pmem_test_prepare/action.yml
line 44 at r3 (raw file):
$WORKDIR/build-pmdk.sh echo '::endgroup::' [[ "${{ inputs.valgrind }}" ]] || { echo "valgrind input is empty" ; exit 1; }
Let's make input validation the first step.
Suggestion:
echo '::group::Validate input'
[[ "${{ inputs.valgrind }}" ]] || { echo "valgrind input is empty" ; exit 1; }
echo '::endgroup::'
echo '::group::Build'
$WORKDIR/build-pmdk.sh
echo '::endgroup::'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
.github/actions/pmem_test_prepare/action.yml
line 44 at r3 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Let's make input validation the first step.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
https://github.com/pmem/pmdk/actions/runs/10099290119/job/27928165433#step:3:3
This change is