-
Notifications
You must be signed in to change notification settings - Fork 21
WIP Use preload tests to test pmemfile-fuse. #437
base: master
Are you sure you want to change the base?
Conversation
9f1d46a
to
c4b3402
Compare
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 78.9% 80.63% +1.72%
==========================================
Files 71 71
Lines 8809 8809
Branches 1774 1774
==========================================
+ Hits 6951 7103 +152
+ Misses 1409 1207 -202
- Partials 449 499 +50
Continue to review full report at Codecov.
|
I'm puzzled why "preload_nested_dirs" fails on Travis with this PR. It passes locally and I can't see anything in the patch that could affect this test. It fails randomly when test tries to create many directories (https://github.com/mslusarz/pmemfile/blob/fuse/tests/preload/nested_dirs/nested_dirs.cmake#L82 ). @GBuella ideas? |
I found only a single place in code where we return EIO: when libpmemfile does not manage to open a pool. Perhaps some more logging, to find out why it can't open the pool sometimes. |
Reviewed 17 of 21 files at r1. Comments from Reviewable |
Reviewed 4 of 21 files at r1. Comments from Reviewable |
This change is