-
Notifications
You must be signed in to change notification settings - Fork 56
doc: librpma discontinuation announcement #2137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
README.md
line 19 at r1 (raw file):
Intel no longer accepts patches to this project. If you have an ongoing need to use this project, are interested in independently developing it, or would like to maintain patches for the open source software community, please create your own fork of this project. You will find more information [here](https://pmem.io/blog/2022/11/update-on-pmdk-and-our-long-term-support-strategy/).
Can we apply this kind of formatting: https://github.com/pmem/libpmemobj-cpp?
Without it, the announcement is almost invisible.
e4c70ba
to
c3ca5ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)
.github/workflows/on_pull_request.yml
line 34 at r2 (raw file):
"N=6 OS=rockylinux OS_VER=8 CC=gcc PUSH_IMAGE=1", # Ubuntu-latest with rdma-core v45.0 installed from sources "N=7 OS=ubuntu OS_VER=latest-with-rdma-core-45 CC=gcc", # disabled intentionaly before project archiving: TESTS_COVERAGE=1",
Suggestion:
# TESTS_COVERAGE=1 disabled intentionally before project archiving
c3ca5ae
to
12308a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)
README.md
line 19 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Can we apply this kind of formatting: https://github.com/pmem/libpmemobj-cpp?
Without it, the announcement is almost invisible.
Done.
.github/workflows/on_pull_request.yml
line 34 at r2 (raw file):
"N=6 OS=rockylinux OS_VER=8 CC=gcc PUSH_IMAGE=1", # Ubuntu-latest with rdma-core v45.0 installed from sources "N=7 OS=ubuntu OS_VER=latest-with-rdma-core-45 CC=gcc", # disabled intentionaly before project archiving: TESTS_COVERAGE=1",
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @janekmi)
bc7dd6c
to
24f3b9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
24f3b9f
to
7c4a491
Compare
Signed-off-by: Gromadzki, Tomasz <tomasz.gromadzki@intel.com>
7c4a491
to
0b42d2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
This change is