Update field order and fix enum values in CorrectPlayerMovePredictionPacket #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
reviewed
Aug 13, 2024
dktapps
reviewed
Aug 13, 2024
dktapps
reviewed
Aug 13, 2024
| $result = new self; | ||
| $result->position = $position; | ||
| $result->delta = $delta; | ||
| $result->onGround = $onGround; | ||
| $result->tick = $tick; | ||
| $result->predictionType = $predictionType; | ||
| $result->vehicleRotation = $vehicleRotation; |
There was a problem hiding this comment.
why is the check removed here?
PHP-CS-Fixer complained about it, and whether its set is only relevant in the encoding process where it needs to be present
TwistedAsylumMC
previously approved these changes
Aug 13, 2024
dktapps
reviewed
Aug 13, 2024
…ement-correction-packet
dries-c
added a commit
to NetherGamesMC/BedrockProtocol
that referenced
this pull request
Aug 14, 2024
commit 9422c97 Author: IvanCraft623 <ivancraft623@gmail.com> Date: Tue Aug 13 19:22:20 2024 -0500 CS fix commit 3b0e82e Author: Dries C <coenendries3@gmail.com> Date: Wed Aug 14 02:07:07 2024 +0200 Fix unread byte in InventoryTransactionPacket commit b6b1ccf Author: Dries C <coenendries3@gmail.com> Date: Tue Aug 13 16:32:28 2024 +0200 Protocol changes for 1.21.20 commit a871e12 Author: Tobias Grether <me@tobiasgrether.com> Date: Tue Aug 13 20:25:54 2024 +0200 Update field order and fix enum values in CorrectPlayerMovePredictionPacket (pmmp#259) commit 5db8d10 Author: Dylan K. Taylor <dktapps@pmmp.io> Date: Tue Aug 13 17:21:12 2024 +0100 Make use of new autogen features in PlayerAuthInputPacket commit a61b555 Author: Dylan K. Taylor <dktapps@pmmp.io> Date: Tue Aug 13 17:20:20 2024 +0100 Allow any static function to have a @generate-create-func tag this allows the creation of internal auto-generated constructors that aren't called create(), which is useful if the public create() wants to do extra validation without losing autogen capability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field order in the CorrectPlayerMovePredictionPacket is wrong, the
predictionTypewas moved to the front of the buffer and there was an additional field of typeVector2for theVehicleRotationadded.Additionally, the
predictionTypeEnum is corrected to be the other way around.