Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: target actor unique ID serialization #271

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

nicholass003
Copy link
Contributor

Fixes #268

@nicholass003
Copy link
Contributor Author

Tested and working fine

Minecraft.2024-09-16.23-33-12.mp4

Copy link
Member

@IvanCraft623 IvanCraft623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TwistedAsylumMC or @dries-c Can you confirm this?

src/types/camera/CameraTargetInstruction.php Outdated Show resolved Hide resolved
src/types/camera/CameraTargetInstruction.php Outdated Show resolved Hide resolved
@TwistedAsylumMC
Copy link

@TwistedAsylumMC or @dries-c Can you confirm this?

Yes, this is correct

dries-c
dries-c previously approved these changes Sep 18, 2024
@IvanCraft623 IvanCraft623 merged commit 440c807 into pmmp:master Sep 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding CameraTargetInstruction to CameraInstructionPacket results in broken packet
4 participants