Protocol changes for 1.21.50 #279
Open
+860
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laith98Dev
reviewed
Nov 25, 2024
Laith98Dev
approved these changes
Nov 29, 2024
KnosTx
approved these changes
Dec 1, 2024
dktapps
requested changes
Dec 3, 2024
src/serializer/BitSet.php
Outdated
| $last = $i + self::SHIFT >= $length; | ||
| $bits |= $last ? 0 : 0x80; | ||
|
|
||
| $buf .= chr($bits); |
There was a problem hiding this comment.
We can use putByte() for this instead of using strings and ord/chr
src/serializer/BitSet.php
Outdated
| $currentShift = 0; | ||
|
|
||
| for($i = 0; $i < $length; $i += self::SHIFT){ | ||
| $b = ord($in->get(1)); |
| } | ||
| self::assertTrue($test->get(64)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Probably a good idea to add a test for the constructor of this class too
|
hasFlag should probably be kept for compatibility |
|
It's a protocol update, we don't care about BC in the protocol. Every update requires breaking stuff anyway. |
dktapps
reviewed
Dec 3, 2024
| @@ -118,20 +125,18 @@ public function write(PacketSerializer $out) : void{ | |||
| $nextShift = $currentShift + self::SHIFT; | |||
| if($nextShift >= self::INT_BITS){ | |||
| $nextShift -= self::INT_BITS; | |||
| $bits |= $parts[++$currentIndex] << (self::SHIFT - $nextShift); | |||
| $bits |= ($parts[++$currentIndex] ?? 0) << (self::SHIFT - $nextShift); | |||
There was a problem hiding this comment.
This shouldn't be needed, the constructor already fills in the blanks
dktapps
reviewed
Dec 3, 2024
| var_dump($i, $a->get($i), $b->get($i)); | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Might want to clean up this debug code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.