Explicit tests for missing type ID constants

pmmp · Nov 12, 2024 · dfc6f01 · dfc6f01
1 parent 6611a81
commit dfc6f01
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/tests/phpunit/block/BlockTypeIdsTest.php b/tests/phpunit/block/BlockTypeIdsTest.php
@@ -51,6 +51,7 @@ public function testVanillaBlocksParity() : void{
 		foreach(Utils::stringifyKeys(VanillaBlocks::getAll()) as $name => $block){
 			$expected = $block->getTypeId();
 			$actual = $reflect->getConstant($name);
+			self::assertNotFalse($actual, "VanillaBlocks::$name() does not have a BlockTypeIds constant");
 			self::assertSame($expected, $actual, "VanillaBlocks::$name() does not match BlockTypeIds::$name");
 		}
 	}

diff --git a/tests/phpunit/item/ItemTypeIdsTest.php b/tests/phpunit/item/ItemTypeIdsTest.php
@@ -54,6 +54,7 @@ public function testVanillaItemsParity() : void{
 			}
 			$expected = $item->getTypeId();
 			$actual = $reflect->getConstant($name);
+			self::assertNotFalse($actual, "VanillaItems::$name() does not have an ItemTypeIds constant");
 			self::assertSame($expected, $actual, "VanillaItems::$name() type ID does not match ItemTypeIds::$name");
 		}
 	}