Items that have contents now drops them on destroy

[JavierLeon9966]

Introduction

Currently when you destroy an item with contents (ex: shulker box) it doesn’t drop them.

Changes

API changes

Added the following methods in Item:

• Item->getContainedItems(): Returns the contents of such item, ex: shulker boxes, chests, brewing stands, hoppers, etc.
• Item->setContainedItems(): Sets the contents of the item.

Added the following method in ContainerTrait:

• ContainerTrait->copyContentsFromItem(): Copied the citem contents into the block entity's inventory.

Added the following helper class:

• pocketmine\block\tile\util\ContainerHelper

Added the following trait:

• pocketmine\block\util\ContainerTrait

Behavioural changes

Any item that has contents in it will now drop them once destroyed. This can include bundles once implemented.

Tests

z90lh0.mp4

[ghost]

Items should also scatter in different directions. Is it provided?

[dktapps]

That's a topic for a different issue. Player deaths should also have the same behaviour but don't.

[ghost]

That's a topic for a different issue. Player deaths should also have the same behaviour but don't.

Will it be in the next next-minor?

[dktapps]

I think it would be better to have some kind of API like Item::getContainedItems() instead of making bogus assumptions about NBT.

[JavierLeon9966]

I think it would be better to have some kind of API like Item::getContainedItems() instead of making bogus assumptions about NBT.

Yeah, especially when the bundle gets implemented. It could’ve a different NBT compared to chests/shulker boxes.
Now this would require item classes for both Chest and ShulkerBox items or some trait like ContainerItemTrait that has this NBT deserializer, and a serializer to let plugins add items with Item::setContainedItems()

[dktapps]

I think it would be better to have some kind of API like Item::getContainedItems() instead of making bogus assumptions about NBT.

Yeah, especially when the bundle gets implemented. It could’ve a different NBT compared to chests/shulker boxes. Now this would require item classes for both Chest and ShulkerBox items or some trait like ContainerItemTrait that has this NBT deserializer, and a serializer to let plugins add items with Item::setContainedItems()

I think a general implementation in Item would be sufficient. I'm just wary of assuming internal item NBT structure from outside and not being able to override it.

[ShockedPlot7560]

Need to be update with the upstream

[JavierLeon9966]

Found 3 issues that are outside the scope of this PR:

• When placing chiseled bookshelves with books in it, it doesn't render on the block
• When placing a brewing stand with blaze powder in it, the fuel time renders full until rendering the block again
• NamingTrait::copyDataFromItem may need to be renamed to NamingTrait::copyNameFromItem to reduce duplicate code

[dktapps]

Looks OK apart from a couple of minor nits