Implement Goat horns #5232
Merged
Implement Goat horns #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonw4331
added
Category: Gameplay
dktapps
added
Type: Enhancement
dktapps
reviewed
Jun 5, 2023
There was a problem hiding this comment.
The PR looks mostly fine, but I'm dubious about the way the sounds are handled.
I feel like the sounds could be done with much less code by having a single GoatHornSound class which accepts GoatHornType and match()es the sound ID.
Is there some advantage to having a class per sound that I'm not seeing?
dktapps
previously requested changes
Jun 5, 2023
- Usage of new native enums instead of EnumTrait - Usage of new IntSaveIdMapTrait - Remove unnecesary GoatHorn*Sound classes
dktapps
reviewed
Feb 20, 2024
|
cooldown is missing :0 |
|
This looks OK, although the cooldown is indeed missing. That should be easily addressed with the merge of #6405. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I've added the missing cooldown.
|
ipad54
approved these changes
Nov 11, 2024
dktapps
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Implement Goat horns and its sounds
Follow-up
Tests
Goat.horns.test.mp4