Split glow lichen multi face logic into traits #6396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonw4331
added
Category: API
dktapps
reviewed
Nov 10, 2024
dktapps
previously approved these changes
Nov 12, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Can we change these to |
ipad54
dismissed stale reviews from github-actions[bot] and dktapps
via
e1d74e2
dktapps
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR splits glow lichen multi face logiс into 2 traits like it's done with other blocks (such as
HorizontalFacingTrait,StaticSupportTrait, etc).These changes are necessary to remove code duplication and make easier implementing other blocks that have multi face logic (such as sculk vein, but Mojang can add more blocks in the future updates).
Changes
API changes
Added
MultiFacingTrait,MultiSupportTraitTests
PHPStan tests are OK.
In-game multi face logic also works fine.