Fix shift crafting #6433
Merged
Fix shift crafting #6433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ShockedPlot7560
added
Category: Gameplay
From what I checked, not really |
ShockedPlot7560
approved these changes
Aug 22, 2024
|
What about the creative item creation, or are you saving that for a separate PR? |
|
I still have to do that, but I'm quite busy now. Maybe someone else can take that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
In versions before 1.21.20, the client will send multiple CraftRecipeStackRequestActions to craft all the items in your inventory. However, since the 1.21.20 shift crafting would throw an error since it now uses repetitions instead of multiple actions and you'd be placing more items in your inventory than you actually crafted from that one action.
Tests
Screen.Recording.2024-08-22.at.22.20.36.mov
I tested this PR by doing the following (tick all that apply):
tests/phpunitfolder)