Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Sugar Cane to break when there is no water #6486

Merged
merged 30 commits into from
Nov 15, 2024

Conversation

bonbionseker
Copy link

@bonbionseker bonbionseker commented Nov 6, 2024

Introduction

This PR allows Sugar Cane to break when it cannot find water.

iloveSugarCane.mp4

Tests

I tested this PR by doing the following (tick all that apply):

  • Playtesting using a Minecraft client (provide screenshots or a video)

Copy link
Member

@dktapps dktapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this vanilla behaviour?

src/block/Sugarcane.php Outdated Show resolved Hide resolved
@bonbionseker
Copy link
Author

vanilla behaviour?

yes it is true vanilla behavior :D

I used Block Type Ids instead of instanceof
@jasonw4331 jasonw4331 added Category: Gameplay Related to Minecraft gameplay experience Status: Waiting on Author Type: Enhancement Contributes features or other improvements to PocketMine-MP Easy task Probably really easy to do, good task for first-time contributors and removed Status: Waiting on Author labels Nov 6, 2024
src/block/Sugarcane.php Outdated Show resolved Hide resolved
yes this is better
src/block/Sugarcane.php Outdated Show resolved Hide resolved
src/block/Sugarcane.php Outdated Show resolved Hide resolved
Copy link
Author

@bonbionseker bonbionseker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

._.

src/block/Sugarcane.php Outdated Show resolved Hide resolved
src/block/Sugarcane.php Outdated Show resolved Hide resolved
src/block/Sugarcane.php Outdated Show resolved Hide resolved
src/block/Sugarcane.php Outdated Show resolved Hide resolved
I edited the events that needed editing :) thanks ipad54
@bonbionseker bonbionseker requested a review from a team as a code owner November 12, 2024 20:08
dktapps
dktapps previously approved these changes Nov 12, 2024
@dktapps dktapps requested review from a team and removed request for jasonw4331, ipad54 and kostamax27 November 12, 2024 21:41
Copy link
Contributor

@kostamax27 kostamax27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

src/block/Sugarcane.php Outdated Show resolved Hide resolved
src/block/Sugarcane.php Outdated Show resolved Hide resolved
By adding "canBeSupportedAt" I made it break when we broke the support block. -.-
formatting issue fix! 👍
src/block/Sugarcane.php Outdated Show resolved Hide resolved
src/block/Sugarcane.php Outdated Show resolved Hide resolved
src/block/Sugarcane.php Show resolved Hide resolved
Name change and formatting issue fix!
@dktapps dktapps merged commit 8474eaf into pmmp:minor-next Nov 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Easy task Probably really easy to do, good task for first-time contributors Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants