Skip to content

Commit

Permalink
fix: e2e react19 fix (#2255)
Browse files Browse the repository at this point in the history
* narrowing react peerDep

* disable CRA temporily (as it installs react19)

* narrow @react-three/fiber to ^8
  • Loading branch information
abernier authored Dec 6, 2024
1 parent c915718 commit 0ae552c
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 18 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,9 @@
"vite-plugin-glslify": "^2.1.0"
},
"peerDependencies": {
"@react-three/fiber": ">=8.0",
"react": ">=18.0",
"react-dom": ">=18.0",
"@react-three/fiber": "^8",
"react": "^18",
"react-dom": "^18",
"three": ">=0.137"
},
"peerDependenciesMeta": {
Expand Down
24 changes: 12 additions & 12 deletions test/e2e/e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -128,22 +128,22 @@ kill_app
# β•šβ•β•β•β•β•β•β•šβ•β• β•šβ•β•β•šβ•β• β•šβ•β•
#

appname=craapp
appdir="$tmp/$appname"
# appname=craapp
# appdir="$tmp/$appname"

# create app
(cd $tmp; npx create-react-app $appname --template typescript)
# # create app
# (cd $tmp; npx create-react-app $appname --template typescript)

# drei
(cd $appdir; npm i $TGZ)
# # drei
# (cd $appdir; npm i $TGZ)

# App.tsx
cp App.tsx $appdir/src/App.tsx
# # App.tsx
# cp App.tsx $appdir/src/App.tsx

# build+start+playwright
(cd $appdir; npm run build; npx serve -s -p $PORT build &)
snapshot
kill_app
# # build+start+playwright
# (cd $appdir; npm run build; npx serve -s -p $PORT build &)
# snapshot
# kill_app

#
# Teardown
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2907,9 +2907,9 @@ __metadata:
vite-plugin-glslify: "npm:^2.1.0"
zustand: "npm:^5.0.1"
peerDependencies:
"@react-three/fiber": ">=8.0"
react: ">=18.0"
react-dom: ">=18.0"
"@react-three/fiber": ^8
react: ^18
react-dom: ^18
three: ">=0.137"
peerDependenciesMeta:
react-dom:
Expand Down

0 comments on commit 0ae552c

Please sign in to comment.