feat(EffectComposer): add dispose (#378)

pmndrs · Sep 12, 2024 · 9d656b2 · 9d656b2
1 parent 0d281ea
commit 9d656b2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/src/postprocessing/EffectComposer.ts b/src/postprocessing/EffectComposer.ts
@@ -195,6 +195,13 @@ class EffectComposer<TRenderTarget extends WebGLRenderTarget = WebGLRenderTarget
 
     this.setSize(this._width, this._height)
   }
+
+  public dispose() {
+    this.renderTarget1.dispose()
+    this.renderTarget2.dispose()
+
+    this.copyPass.dispose()
+  }
 }
 
 export { EffectComposer }
diff --git a/src/postprocessing/Pass.ts b/src/postprocessing/Pass.ts
@@ -24,6 +24,8 @@ class Pass {
   ): void {
     console.error('THREE.Pass: .render() must be implemented in derived pass.')
   }
+
+  public dispose() {}
 }
 
 // Helper for passes that need to fill the viewport with a single quad.

diff --git a/src/postprocessing/ShaderPass.ts b/src/postprocessing/ShaderPass.ts
@@ -52,6 +52,11 @@ class ShaderPass extends Pass {
       this.fsQuad.render(renderer)
     }
   }
+
+  public dispose() {
+    this.fsQuad.dispose()
+    this.material.dispose()
+  }
 }
 
 export { ShaderPass }