Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(*): change 'npm i' to 'npm install' #1015

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 16, 2024

Summary

  • Since this is an official document, I determined that using npm install instead of the abbreviation npm i is more appropriate, so I made the change.
  • In the official homepage, both npm install and npm i are used, so I standardizied them.

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 1:08pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

More templates

npm i https://pkg.pr.new/valtio@1015

commit: 617e93e

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind much, but what do you think? @overthemike

@overthemike
Copy link
Collaborator

I don't mind either way either. They both work just fine.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two zeros and one plus.

@dai-shi dai-shi merged commit e439b11 into pmndrs:main Dec 16, 2024
28 checks passed
@sukvvon sukvvon deleted the docs/npm-i-to-install branch December 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants