Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply publint recommendations #803

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

dbritto-dev
Copy link
Contributor

Related Issues or Discussions

Publint warnings -> https://publint.dev/valtio@1.11.3

Summary

Apply publint recommendations

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 6:49pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a5b8e3:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening up a PR.

package.json Outdated Show resolved Hide resolved
@dbritto-dev
Copy link
Contributor Author

@dai-shi all yours

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbritto-dev dbritto-dev changed the title Apply publit recommendations Apply publint recommendations Nov 1, 2023
@dai-shi dai-shi merged commit 738d425 into pmndrs:main Nov 3, 2023
31 checks passed
@dbritto-dev dbritto-dev deleted the hotfix-publint branch November 3, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants